Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3595 Fix profile bulk update bugs #1773

Merged
merged 2 commits into from
Nov 12, 2024
Merged

IA-3595 Fix profile bulk update bugs #1773

merged 2 commits into from
Nov 12, 2024

Conversation

kemar
Copy link
Member

@kemar kemar commented Nov 5, 2024

Prevent profile bulk update to raise a wrong error when a value is an empty list instead of None.

Related JIRA tickets : IA-3595

Changes

  • for list values, ensure the tasks/create/profilesbulkupdate API treats None as an empty list
  • adapt tests to reflect this and use the full API payload in some of them

How to test

The initial bug was:

  • on the user admin page
  • select a bunch of users to add them a role
  • validate this
  • then realize that the users were not updated due to this error: User without the permission menupermissions.iaso_teams cannot add users to team

This should be fixed and you should be able to perform this operation without any error.

@kemar kemar self-assigned this Nov 5, 2024
@kemar kemar changed the title IA-3595 IA-3595 Fix profile bulk update bugs IA-3595 Fix profile bulk update bugs Nov 5, 2024
@kemar kemar marked this pull request as ready for review November 5, 2024 15:50
@kemar kemar requested a review from quang-le November 7, 2024 16:26
Copy link
Member

@quang-le quang-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +239 to +240
"location_ids_added": [self.jedi_council_corruscant.pk],
"location_ids_removed": [self.jedi_council_endor.pk],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good old jedi council

@kemar kemar merged commit b567fa5 into main Nov 12, 2024
6 checks passed
@kemar kemar deleted the IA-3595-fix-bulk-bug branch November 12, 2024 09:01
@beygorghor beygorghor added user tested Has already been tested on staging Prereleased labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prereleased user tested Has already been tested on staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants