Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IA-3497: Warn the user that is no OUT config is set, users can edit freely #1772

Conversation

hakifran
Copy link
Contributor

@hakifran hakifran commented Nov 5, 2024

Explain what problem this PR is resolving

  • Warn the user that is no OUT config is set, users can edit freely
    Related JIRA tickets : IA-3497

Self proofreading checklist

  • Did I use eslint and black formatters
  • Is my code clear enough and well documented
  • Are my typescript files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • My migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Doc

  • Tell us where the doc can be found (docs folder, wiki, in the code...)

Changes

  • Added a warning message on Change Request Configurations page

How to test

  • Org Units ---> Configuration ---> Change request configuration
  • Check if the warning is there

Print screen / video

Screenshot from 2024-11-05 10-53-26

Notes

Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in bluesquare-components, or merges into another PR (i.o. main), it should also be mentioned here

Copy link
Collaborator

@beygorghor beygorghor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just use an icon ⚠️ instead of Warning ?

@hakifran
Copy link
Contributor Author

Maybe just use an icon ⚠️ instead of Warning ?

Done!!
Screenshot from 2024-11-12 16-46-15

@hakifran hakifran merged commit 22f5bd8 into main Nov 12, 2024
3 checks passed
@hakifran hakifran deleted the IA-3497-warn-the-user-that-is-no-OUT-config-is-set-users-can-edit-freely branch November 12, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants