Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivar_primer_trim rule: calculate 80% of length for trimming #99

Open
rcuadrat opened this issue Feb 8, 2022 · 2 comments
Open

ivar_primer_trim rule: calculate 80% of length for trimming #99

rcuadrat opened this issue Feb 8, 2022 · 2 comments
Labels
prio:High Most urgent issues get this tag type:enhancement any enhancement that doesn't fit into aesthetics, bug or documentation

Comments

@rcuadrat
Copy link
Collaborator

rcuadrat commented Feb 8, 2022

Currently, we have the option -m 180 which means we are removing reads < 180bp. This value should not be hardcoded because we want to allow for different read lengths. I suggest we compute read length automatically as suggested on issue #52 and specify some percentage of the length (for example 80%).

@rcuadrat rcuadrat added prio:High Most urgent issues get this tag type:enhancement any enhancement that doesn't fit into aesthetics, bug or documentation labels Feb 8, 2022
@rcuadrat rcuadrat changed the title iVar rule: calculate 80% of length for trimming ivar_primer_trim rule: calculate 80% of length for trimming Feb 8, 2022
@jonasfreimuth
Copy link
Member

For the moment it is not computed from read lengths, but possible to set it from the settings file...

@jonasfreimuth
Copy link
Member

Also I don't see how iVar allows setting percentages for read-length. Either we would have to process every read individually (involving a lot of overhead, I can't see how this would be feasible without splitting each bam file into separate files for each read), or we could calculate the average read length and calculate the absolute value that is AvgReadLen * PercentReadLen... The average read length migh even already by calculated by one of the QC tools...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:High Most urgent issues get this tag type:enhancement any enhancement that doesn't fit into aesthetics, bug or documentation
Projects
None yet
Development

No branches or pull requests

2 participants