Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step away from modifying column names #158

Open
alexg9010 opened this issue Feb 24, 2023 · 0 comments
Open

Step away from modifying column names #158

alexg9010 opened this issue Feb 24, 2023 · 0 comments

Comments

@alexg9010
Copy link
Member

When searching for variants which share the same signature mutations using the dedupe_sigmut_mat function, the goal is to cluster variants.
We basically transform a matrix of dimension [nAllVar x nMut] into a matrix [nSharedMutVar x nMut].
The column names of the resulting matrix are basically the pasted names of variants with the same signature.

While this might work for a few variants with highly distinct mutations, this approach might cause trouble if more variants are introduced with less variability in their mutations or too little data. This would lead to a larger number of similar variants and potentially very long column names, as recently seen here.

To solve this potential issue I suggest the following solution:

  1. for the dedupe_sigmut_mat function, instead of returning a modified matrix, maybe it would be easier to directly return the group_list aka lineage defined at
    dupe_group_list <- list()
    and iterate over this, subsetting the original matrix in each step of the iteration. This would potentially simplify the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant