Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include databases in release? #102

Open
2 tasks
alexg9010 opened this issue Mar 4, 2022 · 2 comments
Open
2 tasks

include databases in release? #102

alexg9010 opened this issue Mar 4, 2022 · 2 comments
Labels
prio:Med Issues that needs to be fixed in a month type:enhancement any enhancement that doesn't fit into aesthetics, bug or documentation

Comments

@alexg9010
Copy link
Member

The databases used in the tests/settings.yaml are referencing paths on our cluster:
https://github.com/BIMSBbioinfo/pigx_sarscov2_ww/blob/c2044e640766f35fb2bd38a93a1aef4dde382412/tests/settings.yaml#L8-L11

Thus there are two options to solve this issue:

@alexg9010 alexg9010 added type:enhancement any enhancement that doesn't fit into aesthetics, bug or documentation prio:Med Issues that needs to be fixed in a month labels Mar 4, 2022
@rekado
Copy link
Member

rekado commented Apr 14, 2022

The primary goal of the big test is to ensure that we've got all files in the tarball, that all applications run, and that the pipeline runs to completion. The results are not all that important, because for each of the features there should be a separate validation test anyway.

@jonasfreimuth
Copy link
Member

I would consider this resolved once we are able to get distcheck working, which will should be possible with the changes on here (which boil down to having extra rules to download databases if they are not already at the specified locations), and exposing the small database archives I've built on bimsbstatic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:Med Issues that needs to be fixed in a month type:enhancement any enhancement that doesn't fit into aesthetics, bug or documentation
Projects
None yet
Development

No branches or pull requests

3 participants