Skip to content

Add support for dynamic objects #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 14, 2025
Merged

Conversation

adecler
Copy link
Member

@adecler adecler commented Apr 15, 2025

NOTE: Depends on

BHoM/BHoM#1677

Issues addressed by this PR

Addresses the issue raised in the BHoM. See BHoM/BHoM#1677 for more details.

@adecler adecler added the type:feature New capability or enhancement label Apr 15, 2025
@adecler adecler self-assigned this Apr 15, 2025
Copy link

bhombot-ci bot commented Apr 17, 2025

@adecler just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_Engine

Copy link

bhombot-ci bot commented Apr 17, 2025

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_Engine

@adecler
Copy link
Member Author

adecler commented Apr 17, 2025

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 17, 2025

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 13 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented May 13, 2025

@adecler just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

Copy link

bhombot-ci bot commented May 13, 2025

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally works well. Only issue left to handle is creation of subclass of Quantity in the UI does not work, as it gets turned into a numeric type for the output accessor. Might be that we simply exclude them from ever showing up in the UI, or alternatively, make an exception for create methods, to let them actually output the class, rather than double with quantity attribute on the description.

@IsakNaslundBh
Copy link
Contributor

Another nitty gritty thing found. Would be great if the dynamic properties could be sorted on the explode, preferably by the underlying enum value:
image

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check versioning

Copy link

bhombot-ci bot commented May 14, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check versioning

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now working as expected in all cases I have tested for. Code changes also make sense.

Issues found with order fixed:
image

Also now able to create Quantities, while they still show up as numbers on outputs.

Happy with all the changes in here to be merged. Thanks @adecler

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented May 14, 2025

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit e60d5f0 into develop May 14, 2025
6 checks passed
@IsakNaslundBh IsakNaslundBh deleted the BHoM-#1665-DynamicObjects branch May 14, 2025 08:12
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants