-
Notifications
You must be signed in to change notification settings - Fork 6
Add support for dynamic objects #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@BHoMBot check compliance |
@adecler to confirm, the following actions are now queued:
There are 13 requests in the queue ahead of you. |
@adecler just to let you know, I have provided a |
@adecler just to let you know, I have provided a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally works well. Only issue left to handle is creation of subclass of Quantity in the UI does not work, as it gets turned into a numeric type for the output accessor. Might be that we simply exclude them from ever showing up in the UI, or alternatively, make an exception for create methods, to let them actually output the class, rather than double with quantity attribute on the description.
@BHoMBot check versioning |
@IsakNaslundBh to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now working as expected in all cases I have tested for. Code changes also make sense.
Issues found with order fixed:
Also now able to create Quantities, while they still show up as numbers on outputs.
Happy with all the changes in here to be merged. Thanks @adecler
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following actions are now queued:
|
NOTE: Depends on
BHoM/BHoM#1677
Issues addressed by this PR
Addresses the issue raised in the BHoM. See BHoM/BHoM#1677 for more details.