Skip to content

526 contrasting confirmation messages#571

Open
Kafui123 wants to merge 10 commits intodevelopmentfrom
526Contrasting_Confirmation_Messages
Open

526 contrasting confirmation messages#571
Kafui123 wants to merge 10 commits intodevelopmentfrom
526Contrasting_Confirmation_Messages

Conversation

@Kafui123
Copy link
Copy Markdown

@Kafui123 Kafui123 commented Apr 2, 2026

Fixes issue #526

Changes:

  • Fixed the issue where an error message was shown, but a successful flash confirmation still appeared afterward. Now the feedback is consistent... no mixed signals for the user.
  • Adjusted the logic so that success and failure states are clearly separated and reported correctly, instead of overlapping or triggering both paths.
  • Addressed the case where email sending could fail, but the form would still be created, which previously caused a misleading failure message even though the form existed.
  • Ensured that form creation and email sending happen within a single transaction block.

Testing:

  • Click on administration and then manage terms.
  • Select a valid term under any academic year.
  • Create a new labor status form and then click submit
  • If everything succeeded, no flash error message would appear
  • If the form got created, but no email was sent, the form would not get created.
Screenshot 2026-04-02 145031 Screenshot 2026-04-02 145042

@Kafui123 Kafui123 requested a review from Arohasina April 2, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant