-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a button to email the registrar requesting Student SL Course participation #940
Conversation
…ow to make it save the file in data base
…to buttonRegistrar
…ctionality of it
…right corner of the modal box
… file or closing the modal after selecting a file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move the test files into a files/
directory inside tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I got an error when I made a course abbreviation 4 digits instead of 3:
previousTerm = list(Term.select().order_by(Term.termOrder))[-1].termOrder > Term.convertDescriptionToTermOrder(cellVal) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: '>' not supported between instances of 'str' and 'NoneType'
-
I got an error when I made the term "Fall 21" instead of "Fall 2021"
-
The whole course and other participants disappears from the preview when there is an error with one of the bnumbers. Also, I would probably put the error in-line with the course and other participants, rather than put it at the end.
-
The whole course disappears if there is a blank line after the course abbreviation and before the participant list starts.
-
Same problem if there is a blank line after the term
… modal while not breaking the code from running
… modal while not breaking the code from running
…ncluding errors and deleted the error list
…fter the first term in the list.
…e we saved participants to the database.
…Participant object when we attempt to get it before creating the new object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure the buttons look ok when the page width shrinks.
…nstead of any whitespace character, described their function, added check for A and B for spring and fall terms. Addressed additional changes as requested.
…/celts into buttonRegistrar
Issue:
We need a new button to upload excel sheets to the admin page to allow the automation of courses and course participant creation in the database.
Fixes:
Added two main logic functions parseUpload and pushCourseParticipantToDatabase which control the file upload from the manageServiceLearning page. These functions parse the data in an excel sheet prepare it for preview and upload the data to the database when the user confirms. Added modals to preview and submit data from the excel sheet.
Tests:
To test our changes, create excel sheet in the format of:
Term
Course Abbreviation
Participants(their B numbers and full names)
If a future term doesn't exist or a participant's username is not in the database, there should be an error message and it should disable the submit button. Otherwise, it should display the Term, Course and added students FirstName LastName.
Resolves #646