Allow the creator of the Course Proposal to renew it #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonStettner
requested changes
Jun 16, 2023
BrianRamsay
previously approved these changes
Jun 16, 2023
…correctly. More specifically, it failed to find the correct selector id because we forgot the # before the id in javascript
…nsistent with the other buttons on the page. That is, set the onclick attribute of the tag.
…ess or print action.
…ck arrow and the selections would not reset.
|
We've finished fixing all of the noted issues. We are ready to be pulled. Resolves #891 |
AndersonStettner
requested changes
Jun 20, 2023
AndersonStettner
requested changes
Jun 20, 2023
…leted unnecessary portion (value=).
AndersonStettner
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether the current user has created the course and allow him to renew a Course Proposal.
We were unable to recreate the bug where faculty members could not renew proposals for which they were among the faculty.
This feature was working properly and looks fine in the code.
Resolves #891