Restricted permissions to the course management page #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the user doesn't have permissions instead of redirecting them with a warning.
BrianRamsay
requested changes
Jun 15, 2023
|
|
||
| isRequestingForSelf = g.current_user == user | ||
| if g.current_user.isCeltsAdmin or (g.current_user.isFaculty and isRequestingForSelf): | ||
| setRedirectTarget("/serviceLearning/courseManagement") |
There was a problem hiding this comment.
Instead of always coming back to /serviceLearning/courseManagement in setRedirectTarget, we should come back to the original route they came in on (including the username if necessary). Check out the flask request object
hoerstl
commented
Jun 15, 2023
|
|
||
| isRequestingForSelf = g.current_user == user | ||
| if g.current_user.isCeltsAdmin or (g.current_user.isFaculty and isRequestingForSelf): | ||
| setRedirectTarget("/serviceLearning/courseManagement") |
…te where the user came from and not our own course management page.
…ntSoftwareDevTeam/celts into Individual-course-management-929
|
We have fixed the redirection issue! May we merge now? |
BrianRamsay
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've changed the permissions for the course management pages for users to be restricted to all administrators and faculty that are attempting to view their own page. Faculty cannot view other faculty's pages and students should not have one so they cannot either.
Fixes issue #929