Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making the drop down disappear when the bonner button is checked #931

Merged
merged 16 commits into from
Jul 17, 2023
Merged

making the drop down disappear when the bonner button is checked #931

merged 16 commits into from
Jul 17, 2023

Conversation

doucoureb
Copy link
Contributor

No description provided.

@AndersonStettner AndersonStettner linked an issue Jun 14, 2023 that may be closed by this pull request
Hide all other visibility options when creating notes if "Related to Bonner..." is checked #901
Closed
AndersonStettner
AndersonStettner requested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@AndersonStettner AndersonStettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The location/position of the footer have been a bit messed up. I have put screenshots below that show how it looks on your branch and how it looks on development. This is probably caused by a missing

or
tag somewhere.

Your Branch:
image

Development:
image

BrianRamsay
BrianRamsay requested changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@BrianRamsay BrianRamsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to make sure that setting a bonner note ignores the visibility setting. Possibly this will mean adding a new visibility setting only applicable to bonner notes.

app/static/js/userProfile.js Outdated Show resolved Hide resolved
app/static/js/userProfile.js Outdated Show resolved Hide resolved
app/templates/main/userProfile.html Outdated Show resolved Hide resolved
@BrianRamsay
Copy link
Contributor

We also need to address the behavior when we click the Add Bonner Note button. The modal should only have the visibility message and the note field.

AndersonStettner
AndersonStettner requested changes Jun 20, 2023
View reviewed changes
app/templates/main/userProfile.html Outdated Show resolved Hide resolved
app/templates/main/userProfile.html Outdated Show resolved Hide resolved
app/templates/main/userProfile.html Outdated Show resolved Hide resolved
AndersonStettner
AndersonStettner requested changes Jul 10, 2023
View reviewed changes
app/static/js/userProfile.js Outdated Show resolved Hide resolved
AndersonStettner
AndersonStettner requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@AndersonStettner AndersonStettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When "For Bonner" is checked, we want to ignore all the other note visibility options.

@AndersonStettner
Copy link
Contributor

Hide all other visibility options when creating notes if "Related to Bonner..." is checked #901

@github-actions
Copy link

View Code Coverage

@BrianRamsay BrianRamsay merged commit c31d386 into development Jul 17, 2023
5 checks passed
@BrianRamsay BrianRamsay deleted the fixVisibilityBonner branch July 17, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianRamsay BrianRamsay BrianRamsay requested changes

@AndersonStettner AndersonStettner AndersonStettner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide all other visibility options when creating notes if "Related to Bonner..." is checked
3 participants
@doucoureb @BrianRamsay @AndersonStettner