-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rsvp Limit and Waitlist #885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is actually doing.
…ts into limitRsvp
…ts into limitRsvp
…ts into limitRsvp
This was
linked to
issues
May 15, 2023
…ton when it is a past event (button is temp)
… to be added to waitlist and changed the title of the modal depending on where the volunteer was going to be added
…anch for a different issue
BrianRamsay
requested changes
Jun 7, 2023
…reDevTeam/celts into rsvpAndVolunteerRefactor
BrianRamsay
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #748
For Issue #748:
Added a new column to the Event table
rsvpLimit
and created a functiongetEventRsvpCountsForTerm()
in events.py to get the amount of people that have RSVPd to an event. The RSVP button is enabled/disabled based off the current RSVP amount. The wording on the Event View page now changes based off of whether or not RSVP is required, if there is a limit or not, and how many spots are left if there is a limit. When the RSVP limit is reached volunteers will be added to the Waitlist table, which is under the RSVP table on thetrack_volunteers
page, and Admin can delete and add users from the waitlist table to the RSVP table manually, regardless of limit. The waitlist table should only be visible when there are people in it.Did:
RSVP History
tab.rsvpLimit
column to the Event model and arsvpWaitlist
column to the EventRsvp table.track_volunteers
page. The waitlist table should only appear when there is a person in it.Add to RSVP
button in the waitlist table which allows CELTS Admin to move someone from the waitlist to RSVP regardless of the current number of volunteers that have RSVPd. This is only manual and volunteers are never moved from waitlist to RSVP as was requested by CELTS.Add Volunteer
modal name and button change to accurately describe what they are doing.RSVP
buttons in the application now change toJoin Waitlist
if the RSVP limit has been reached.track_volunteers
page when the RSVP limit has been reached to let the user know the people they are adding will be put into the waitlist.View Event
page so that potential volunteers will be aware when they are being put on a waitlist.EventRsvpLogs
model that will have the RSVP history in it.To Test:
rsvpAndVolunteerRefactor
database/reset_database.sh test
tests/run_tests.sh
and verify that all tests passflask run
Add Volunteers
modal on thetrack_volunteers
page. Once you reach the limit you have set verify that the warning about future additions being added to the waitlist appear.Add to RSVP
works as it should.Event View
and make sure it says the limit when there is one, informs the user they will be added to a waitlist when the limit has been reached, and just says RSVP required when there is no limit.Add Volunteer
modal change to accurately reflect what they are doing as you add people to the RSVP and waitlist tables.RSVP
buttons change toJoin Waitlist
when the RSVP limit has been reached.