Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix User Profile Events #1328

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Fix User Profile Events #1328

merged 4 commits into from
Aug 30, 2024

Conversation

ojmakinde
Copy link
Contributor

Issue Description

Fixes issue #1314
The issue was fixing a poor color choice on event highlighting. A few other changes were also added.

Changes

  • Fixed conditional logic for highlighting ongoing events and greying past events.
  • Added sorting logic for Upcoming Events to sort by start time.
  • Changed highlight color for events in progress.
  • Added End Date column.

image

Testing

  • Pull this branch.
  • Run the test suite, and ensure the stated changes work.

@ojmakinde ojmakinde changed the title User profile event fix Fix User Profile Events Aug 29, 2024
@github-actions GitHub Actions
Copy link

View Code Coverage

@BrianRamsay BrianRamsay merged commit 1daf86c into development Aug 30, 2024
5 checks passed
@BrianRamsay BrianRamsay deleted the User-Profile-Event-Fix branch August 30, 2024 13:49
@ojmakinde ojmakinde linked an issue Sep 3, 2024 that may be closed by this pull request
Highlight of the today's event on the My Profile page #1314
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianRamsay BrianRamsay BrianRamsay approved these changes

Assignees

@BrianRamsay BrianRamsay

@bledsoef bledsoef

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight of the today's event on the My Profile page
3 participants
@ojmakinde @BrianRamsay @bledsoef