Validate for Duplicate Event Entries within Multiple Offering Modal #1327
Conversation
…m save the modal and cleaned up code
There was a problem hiding this comment.
Great work altogether! The only issue is an edge case where we get an error when trying to create an event in the multiple event offerings modal when one already exists in the database. It should probably prevent you from creating it in the first place. @stevensonmichel speak more with Lawrence about this he understands how it works.
…k which offerings failed to save and report that info to the user
…:BCStudentSoftwareDevTeam/celts into 1306-Multiple-Offering-Duplicate-Entries
…ransactions when one multiple offering fails and how we use the restructured outputs from the attemptSaveMultipleOfferings function
…correctly and refactored.
app/controllers/admin/routes.py
Outdated
|
|
||
| event_dates = [event_data[0].startDate.strftime('%m/%d/%Y') for event_data in savedEventsList] | ||
| elif len(savedEvents) >= 1 and eventData.get('isMultipleOffering'): | ||
| event_dates = [event_data.startDate.strftime('%m/%d/%Y') for event_data in savedEvents] |
There was a problem hiding this comment.
Can we make this camel case instead of snake?
app/controllers/admin/routes.py
Outdated
|
|
||
| event_list = ', '.join(f"<a href=\"{url_for('admin.eventDisplay', eventId=event.id)}\">{event.name}</a>" for event in modifiedSavedEvents) | ||
| event_list = ', '.join(f"<a href=\"{url_for('admin.eventDisplay', eventId=event.id)}\">{event.name}</a>" for event in savedEvents) |
There was a problem hiding this comment.
Can we make this camel case instead of snake?
| @@ -95,6 +96,52 @@ def deleteAllRecurringEvents(eventId): | |||
| eventId = allRecurringEvents[0].id | |||
| return deleteEventAndAllFollowing(eventId) | |||
|
|
|||
| def attemptSaveMultipleOfferings(eventData, attachmentFiles = None): | |||
app/logic/events.py
Outdated
| @@ -105,7 +152,7 @@ def attemptSaveEvent(eventData, attachmentFiles = None, renewedEvent = False): | |||
| If it is not valid it will return a validation error. | |||
|
|
|||
| Returns: | |||
| Created events and an error message. | |||
| The saved event Created events and an error message if an error occurred. | |||
There was a problem hiding this comment.
Nit: Reword to "The saved event, created events, and an error message if an error occured."
| } | ||
| } | ||
|
|
||
| if (isEmpty){ |
There was a problem hiding this comment.
Some of the code in this conditional and following conditionals seem to be redundant. Can we potentially create a new function that has a parameter that can be passed in to ('.invalidFeedback').text() since the rest is identical.
Issue Description
There is no form validation preventing a user from creating multiple of the same event using the multiple offerings modal. Currently, when they try, the form submits and returns a warning that the "event already exists" because it is a duplicate event. This is not intended behavior and the user should be warned beforehand.
Fixes issue #1306
Changes
Dev Note: After careful consideration, we determined that we should prevent a user from creating two offerings of an event if they had the same name, date, start time, even when they have different end times. We cannot think of a situation when two events wouldn't be the same even with different end times.
Testing
First, prepare your local development environment and run the application
Preparation:
source setup.shdatabase/reset_database.sh testflask runNow, you should create an event under any program and click the slider to give the event multiple offerings.
In the modal, do your best to create duplicate events and save the event page. If you cannot create multiple offerings so that when you save the event, you get a warning message saying that the "event already exists", then our PR is working.
Try creating two events that have the same fields but differ once in each of the following areas per test:
All fields same except event name
All fields same except event date
All fields same except start time
e.x.
