Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Save Button Spacing #1317

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fixed Save Button Spacing #1317

merged 3 commits into from
Aug 29, 2024

Conversation

ojmakinde
Copy link
Contributor

Issue Description

Fixes issue #1313

  • On the Create Event page, there was a spacing error between the Save button at the bottom of the page and the footer.

Changes

  • Added a margin to the Save button element
  • Also edited the markdown on the Pull Request Template

New look:
image

Old look:
image

Testing

  • Pull the branch and navigate to the Create Event page
  • The Save button should have better spacing.

@github-actions GitHub Actions
Copy link

View Code Coverage

bledsoef
bledsoef approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright I guess.

@bledsoef bledsoef merged commit 492e97b into development Aug 29, 2024
5 checks passed
@bledsoef bledsoef deleted the Save-Button-Margin branch August 29, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bledsoef bledsoef bledsoef approved these changes

@BrianRamsay BrianRamsay Awaiting requested review from BrianRamsay

Assignees

@vungc vungc

@ojmakinde ojmakinde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ojmakinde @bledsoef @vungc