Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pull Request Template #1309

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Added Pull Request Template #1309

merged 4 commits into from
Aug 27, 2024

Conversation

ojmakinde
Copy link
Contributor

@ojmakinde ojmakinde commented Aug 22, 2024

Issue Description

Fixes issue #_add issue number

  • Brief issue description

Changes

  • Use bullet points to provide a description of added changes
  • Add images where possible to provide more context to your changes

Testing

  • Use backticks to highlight shell commands or file directories in your test descriptions.
  • Use bullet points to provide a description of added changes

bledsoef
bledsoef previously approved these changes Aug 25, 2024
Copy link
Contributor

@bledsoef bledsoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but again, would just consider removing the first underscore after the # as it may add some confusion. Approving as you can choose to remove that or not

Copy link

View Code Coverage

@BrianRamsay BrianRamsay merged commit 6365cd9 into development Aug 27, 2024
5 checks passed
@BrianRamsay BrianRamsay deleted the PR-Template-Builder branch August 27, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants