Events list indicators #1304
Merged
Events list indicators #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
each event type. Added ajax request to event list JS. Not working
Student led service counter counts the amount of event type categories under the header rather than the amount of events, need to fix that :/
led events. The total term event count is still displayed instead of upcoming even if past term is toggled on. This is the next fix
request now handles each term rather than just one still need to have total numbers when past term toggle is on and only show upcoming by default
indicator, ideally we will show indicators for past when the toggle is on.
student led and now the toggle is also busted
toggles. Toggle stays consistent accross pages and its state is now properly held in the backend. Cleaned up debug statements and unused comments/ code.
|
There are no changes reflected on the events list page. |
…ts into events-list-indicators
…DevTeam/celts into events-list-indicators
@Karina-Agliullova there was a broken file, resolved this. This issue should be good to go now. |
…DevTeam/celts into events-list-indicators
…DevTeam/celts into events-list-indicators
ojmakinde
previously approved these changes
Aug 22, 2024
WackyWeaver
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added indicators at the top of the event list page for each category to show how many events there are. Works for past events and upcoming.
#1299 - git issue
https://trello.com/c/mGeAmVOi - trello