Generalized spreadsheet.py and refactored test_spreadsheet.py #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts into generalize-spreadsheet
…n and an input bar for the year to download the report.
… the 'select box' and 'label', and renamed the download button to 'Download' and moved the Excel icon infront of the name.
…he page needs to reload every time it is toggled and does not save the past event tables after reloading
… changed while past terms are always on and disabled and tables are displaying all the time when toggle is on and not displaying when toggle is off
…ts into generalize-spreadsheet
…DevTeam/celts into generalize-spreadsheet
BrianRamsay
reviewed
Jul 31, 2024
… hard-coded parameters, and caught ordering issue
…SoftwareDevTeam/celts into generalize-spreadsheet
BrianRamsay
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the functionality of spreadsheet.py did not specify a specific year. Many of the peewee queries did not filter for academic year. We joined all necessary tables to allow spreadsheets to return data for a specified academic year.
Refactored the 14 spreadsheet.py unit tests to include fixtures independent from test data. Removed unnecessary rows in test objects within the test functions. simplified asserted functions and created a much more
Resolves #1289