Create Events Page: Split the toggle buttons into 2 sections, and make one of 3 toggles required #1296
Merged
BrianRamsay merged 16 commits intodevelopmentfrom Jul 25, 2024
Merged
Create Events Page: Split the toggle buttons into 2 sections, and make one of 3 toggles required #1296BrianRamsay merged 16 commits intodevelopmentfrom
BrianRamsay merged 16 commits intodevelopmentfrom
Conversation
page. Added dividing line and styling in new file createEvent.css. Need to ask if we want toggle to check if event is Bonners
toggle. laid out click handler for toggle switches to implement tomorrow
one category in create event page now. Fixed formatting for when the webpage is in a smaller window.
event edit page.
groups when the page is small
the user selectes to create a bonner event.
that is not checked as bonners, but the user has freedom to check other boxes if wanted
Contributor
Author
|
#1294 - github issue https://trello.com/c/50TXOdHE - trello card |
event tab now reflects whether the event is bonners or not
BrianRamsay
requested changes
Jul 25, 2024
Contributor
BrianRamsay
left a comment
BrianRamsay
left a comment
There was a problem hiding this comment.
The bonner toggle only should be there for Bonner events.
Let's clean up the html classes and styles and try and simplify what controls the width of the components. Use the bootstrap grid only, if possible, for rows and columns.
selected, but if a new toggle is selected, the others are untoggled and the click one is on. Gave the divider line its own div, but it sill needs formatting work.
window is below a certain size
BrianRamsay
requested changes
Jul 25, 2024
Contributor
BrianRamsay
left a comment
BrianRamsay
left a comment
There was a problem hiding this comment.
Let's clean up the css so we are relying more on bootstrap. the cutoff point should be xl, then you don't need min-width or the @media selector
app/static/js/createEvents.js
Outdated
| // Determine which checkbox was clicked and its current checked status, uncheck others | ||
| $("#checkIsTraining, #checkServiceHours, #checkBonners").on('click', function (event) { | ||
| let $target = $(event.target); | ||
| $("#checkIsTraining, #checkServiceHours, #checkBonners").not($target).prop('checked', false); |
Contributor
There was a problem hiding this comment.
we can just use $(event.target) in the not()
media sizing in CSS, removed JS variable and added its code directly to the line it was used in.
BrianRamsay
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bonners toggle will automatically toggle for Bonner events, but can be changed by the user if they wish and other event types can also use this toggle. The toggle state is saved between create event and edit event. The toggles are divided as requested into required and optional categories as well.