-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Program Management section of Admin Settings #1281
base: development
Are you sure you want to change the base?
Conversation
saving solution in route, currently get system error.
some white space and useless comments and moved some css to its proper location. Image solution still doesn't work, will ask a higher power about it on monday
file handler, was trying to use userManagement.py
except as a foreign key value in program to store one charfield variable. Add some things to hopefully handle files, not working. Updated the test data to contain added data fields.
some variables
…rrently attempting to change the file name to the name of the program along with the file extension.
…dal and the msgToast is also in front of the modal and clearly visible.
…ts still not passed FileStorage issue.
Merge branch 'refactorProgramMgmt' of github.com:BCStudentSoftwareDevTeam/celts into refactorProgramMgmt
Merge branch 'refactorProgramMgmt' of github.com:BCStudentSoftwareDevTeam/celts into refactorProgramMgmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI needs a little work. Buttons may be better as "Edit Details", Program names shouldn't be <input>
tags, which should fix the table column width. Buttons should be normal sized.
Merge branch 'refactorProgramMgmt' of github.com:BCStudentSoftwareDevTeam/celts into refactorProgramMgmt
Merge branch 'refactorProgramMgmt' of github.com:BCStudentSoftwareDevTeam/celts into refactorProgramMgmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We forgot about the case when a program name changes. The current logic means it can no longer find the uploaded image.
Let's store the file path in coverImage (like we do in AttachmentUpload). This way, when the name changes we don't have to do anything. This will mean changing how the image is referenced on the home page, as well as how we delete images when we upload a new one.
The table for the programs is a little narrow. 350px minimum width would fit better. Also, the header Program should be centered.
Merge branch 'refactorProgramMgmt' of github.com:BCStudentSoftwareDevTeam/celts into refactorProgramMgmt
For the issue with the cover images of programs, it seems like uploaded photos are not stored, but their information is saved to the file under the program's name on the landing page. The field "coverImage" under Program still stores the original file's name. When the landing page loads, it makes the assumption that each program has the image equal to it's program. I need to keep the photo somewhere different, or I need to correct the assumption that landingPage.py is making. |
Issue: #797