fixed renew button issue in course proposal page #1258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Ali, the View side is perfect so does the JavaScript file just need some clean up I feel like comments on line 45 and 48 can be deleted as they are repeating what the code below does when the codes after the comment are easy to understand. |
|
Already fixed this and the additional renew onclick you added is unnecessary, thank you though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: 1257 | Issue Link: 1257
The renew button had an issue and the renew function wasn't catching the value sent from the UI. The problem was the ajax call wasn't being made and the function wasn't returning anything. We fixed it by adding $('#renewBtn').on('click', renew); to the .ready() function at the top to capture ajax call.