Import courses #1252
Merged
Import courses #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e data from the table
…hrough dictionary
…hrough dictionary
…hrough dictionary
…s, IF the course already the course already
…DevTeam/celts into import_courses hehhe
s are in the same semester
…rsame course and term and puts pparticipants into existing courses.
…rsame course and term and puts pparticipants into existing courses and comments deleted
…eDevTeam/celts into import_courses
|
Reviewing this PR with Seedy |
|
Made code review and used unintended inputs yet it still works just fine. I recommend commenting/documenting code though. |
BrianRamsay
requested changes
Jul 25, 2024
…proposals into creating course proposals.
…om proposals as part of functionality of adding course proposals.
…DevTeam/celts into import_courses updating functionality of function
…ncluded in the same function.
AravDe
commented
Jul 29, 2024
…DevTeam/celts into import_courses\ pulling in from developement
BrianRamsay
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the functionality of importing courses. When a course is imported, it checks if it already exists in the courses table. If it does exist then it copies the all information other that status(originally it was just directly set to 4, so we did not change it) and term (because term might be different). It does not check if the course exists in the same term anymore. On discussion with Karina, she pointed out that we should not completely rule out on the basis on term as there might be multiple sections of a class with the same course name and term. Maybe we can add another enhancement where it checks for the section but I don't think we are able to import sections through the spreadsheet. Have not tried to import it yet.
Issue : #1180
New Updates
On discussion with Brian, we decided that we are going to ignore the case of sections for now and not add any courses that have the same course abbreviation or term. We checked for three conditions. If the Course Abbreviation and Term is the same, we add the course participants. If the Course Abbreviation is the same and the term is different there are two sub-conditions. If the term is older than that of the most recent Course Abbreviation match, a new course is added without copying any information. If the term is newer than that of the most recent Course Abbreviation match, a new course is added but with information copied from the match. If none of the Course Abbreviation or term match, we enter a new course into the table.