Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added full name to emergency contact updates as well as insurance updates in admin logs (updated) #1247

Closed
wants to merge 7 commits into from
Closed

Added full name to emergency contact updates as well as insurance updates in admin logs (updated) #1247

wants to merge 7 commits into from

Conversation

JohnCox2211
Copy link
Contributor

@JohnCox2211 JohnCox2211 commented Jun 26, 2024 •
edited by esw0624

No more duplicates are allowed in DB for emergency contacts and insurance info. They are also properly
displayed when changed in the admin logs now.
#1124

JohnCox2211 and others added 6 commits June 26, 2024 10:47
@JohnCox2211
added some stuff to hopefully bring back admin log
ea553d4 
changes
@JohnCox2211
added adminLog class file and function in logs
8ed6c1d 
file. Added capability to submit info change log,
but its not working for some reason, probably need
help
@JohnCox2211
removed adminlog feature since it was a duplicate
c53f487 
feature of activitylog. There is an issue moving
from the edit insurance info page to the emergency
contact info page, but not the other way around
this is the issue we now need to solve
@JohnCox2211
Fixed the issue of duplicate entries being allowed
6531478 
for emergency contacts and insurance info. The
above also show proper admin logging now as well.
@JohnCox2211
No more duplicates allowed in DB for emergency
a5967c5 
contacts and insurance info. The above are properly
displayed when changed in the admin logs now.
@JohnCox2211
Update routes.py
4046d4f 
removed prints
@JohnCox2211
Copy link
Contributor Author

This issue is a continuation and fix for merge errors that broke this fix: #1212

@github-actions GitHub Actions
Copy link

View Code Coverage

BrianRamsay
BrianRamsay requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@BrianRamsay BrianRamsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contactInfo will be empty if there is no emergency contact for that user yet (which will fail later when we create the activity log)
Logic for when to create the contact info doesn't work

@esw0624 esw0624 closed this Jul 18, 2024
@esw0624
Copy link
Contributor

esw0624 commented Jul 18, 2024

Made a new branch for this issue, so closing this branch and PR.

@esw0624 esw0624 deleted the logEmergencyContacts branch July 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CollegeStevenLN CollegeStevenLN CollegeStevenLN left review comments

@BrianRamsay BrianRamsay BrianRamsay requested changes

Assignees

@JohnCox2211 JohnCox2211

@esw0624 esw0624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JohnCox2211 @esw0624 @BrianRamsay @CollegeStevenLN