Removed rows from canceled course proposals #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianRamsay
requested changes
Jun 27, 2024
…ts into empty-course-row
BrianRamsay
requested changes
Jun 28, 2024
AravDe
reviewed
Jul 29, 2024
| @@ -189,7 +189,12 @@ def withdrawProposal(courseID) -> None: | |||
| except DoesNotExist: | |||
| print(f"File, {AttachmentUpload.fileName}, does not exist.") | |||
|
|
|||
| # delete course object | |||
| # deletes course | |||
There was a problem hiding this comment.
This comment is not needed, the line right after describes what is going on pretty well in my opinion
BrianRamsay
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added an ajax request onto the cancelButton event handler that routes to a new route 'canceledProposal'. If the proposal has no course name and abbreviation, then the course row is deleted in the database as well as the dependent row from the course questions table.
Resolves #1210