Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X button fix (On import participants page) #1219

Closed
wants to merge 17 commits into from
Closed

X button fix (On import participants page) #1219

wants to merge 17 commits into from

Conversation

thealphagurlux
Copy link

@thealphagurlux thealphagurlux commented Jun 17, 2024 •
edited
Loading

Made a new function for the x button in a pop-up modal on the participant import page. (closeModalPreview)

@JohnCox2211
Copy link
Contributor

link to issue #1179

BrianRamsay
BrianRamsay requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@BrianRamsay BrianRamsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for the X! Good job. For some reason, the Cancel button doesn't work, though the ticket indicates that it does. Can you make your fix work for Cancel as well? Not sure how it got disconnected from that route.

@github-actions GitHub Actions
Copy link

View Code Coverage

@JohnCox2211 JohnCox2211 mentioned this pull request Jul 25, 2024
Merged
@JohnCox2211
Copy link
Contributor

resolved and merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianRamsay BrianRamsay BrianRamsay requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thealphagurlux @JohnCox2211 @BrianRamsay