Graduation flag #1218
Merged
Graduation flag #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eDevTeam/celts into graduation-flag
|
The code works! We manually added the true boolean in database and it shows. |
BrianRamsay
previously approved these changes
Jul 26, 2024
|
There is a problem with a class level and hasGraduated functionality. So, if I change test data and make one of the students a graduated student, it shows a graduation flag, which is what we want. However, the class level is not being checked, so even if we flag a junior student as a graduated student, it would still show us a graduation flag, even though on the profile, we can see, that the person is still a junior student. |
|
@BrianRamsay @Karina-Agliullova Going to approve and merge this and put in a new issue to allow admin to manually add students as graduated. |
bledsoef
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added a column to the User module for the hasGraduated and then we tested it using the test database. Graduation cap has been added to the minor management page, and there's a icon next to names of those have graduated.
resolves #1141