-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selectively remove service transcript entry for banned programs #1176
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good! I found a couple of bugs but they don't seem too difficult to iron out. Once you fix the non-displayed program hours ending up in the transcript total and that one modal-title
selector changing all modal titles on the user's profile this looks good!
So I found an issue of when you ban a user, remove that program from their transcript, and then unban the user, it is still removed from the transcript. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR functionality and code look good. However, I have a few suggestions:
- It would be good to add some confirmation after (un)removing a program from a student's transcript. The only way I could tell changes were being made was looking at the POST requests on my flask session. A flash or basic confirmation would improve feedback.
- Using a radio instead of a checkbox would also look better.
- Adding the "Remove from Transcript" to the main page instead of the Edit Modal would also make the functionality better. Greying out the function until the event is banned would be a viable way to implement its current functionality.
Issue: #658
Add a checkbox to the ban modal dialog to choose whether to completely remove the program from the service transcript or keep it in the service transcript (in case if the checkbox is not clicked). The checkbox on the modal should affect the service transcript directly and remove or keep the programs, whose modals were checked/unchecked.
Did:
removeFromTranscript
in programBan tableTest:
serviceTEntry658