979 syllabus upload button change #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… optimization required
BrianRamsay
requested changes
Jul 17, 2023
…to a form submit that redirects to the next tab. This will hopefully allow us to upload files.
… effectively doubling each fac entry on the course.
… & exit button to be the actual saveExit button
…handleFileSelection'
…h the courseId and eventId information respectively when deleteing attachments from a thing since it needs to be attached in a single js file.
…d of having it defined locally.
…hich we can include on any page where we want to display file attachments!
…ove button. Also fixed another bug where you were allowed to submit a form that didn't have valid information, namely you could have zero course instructors assigned to the course.
BrianRamsay
requested changes
Jul 19, 2023
…e is true for the save & exit button on the edit course proposal page, both are functional.
BrianRamsay
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upload button on the Course Proposal page has been updated. In the process of replacing it with the existing view in the Create Event page, the team decided it would be best to integrate the Create Event code into a function, and have it called wherever it is needed.
In the process of refactoring, certain parts of the function were optimized and condensed, improving readability and conciseness.
The function now exists in base.js, and is called in the CreateEvent.js and slcNewProposal.js files.
Code can be tested by uploading attachments in the Create Events page and the Course Proposals page.
Resolves #979