You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
작업 만료 시간인 expiresAt과 재시도 시간인 nextAttemptAt에 @Convert(disableConversion = true)를 적용해 JPA의 기본 날짜 매핑을 사용하도록 합니다.
기존 작업 배정 서비스 테스트에서 소수점이 있는 시간으로 저장과 조회를 검증하고 두 필드의 시간 정밀도가 유지되는지 확인하도록 보완합니다.
💬 참고 사항
두 필드의 매핑만 변경하므로 공용 날짜 변환기 수정이나 DB 마이그레이션은 필요하지 않습니다.
삐봇 API의 요청과 응답 형식은 유지합니다.
✅ Checklist (완료 조건)
코드 스타일 가이드 준수
테스트 코드 포함됨
Reviewers / Assignees / Labels 지정 완료
보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)
Summary by CodeRabbit
Bug Fixes
Dining report delivery now handles retry and lease-expiration times with fractional-second precision. Failed deliveries retain the expected five-second retry delay, and delivery leases retain the expected 60-second expiration window. This improves the consistency of delivery timing when timestamps include fractions of a second.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
Walkthrough
The dining report delivery entity disables attribute conversion for expiresAt and nextAttemptAt. Acceptance tests use a fractional-second clock value and verify the five-second retry delay and 60-second lease expiry.
Changes
Dining report delivery timestamps
Layer / File(s)
Summary
Timestamp mapping and delivery assertions src/main/java/in/koreatech/koin/domain/dining/model/DiningReportChange.java, src/test/java/in/koreatech/koin/acceptance/domain/DiningReportDeliveryServiceTest.java
The entity disables attribute conversion for expiresAt and nextAttemptAt. Acceptance tests use a fractional-second start time and verify the expected retry and lease-expiry timestamps.
The delivery timestamps retain microsecond precision through the database mapping, with no actionable merge risk apparent.
Pre-merge checks | 4 | 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly identifies the main change: fixing a time conversion error in sold-out report delivery tasks. It matches the code and test changes.
Linked Issues check
직접 연결된 공개 이슈 #2485의 요구사항을 충족합니다. DiningReportChange.expiresAt 및 nextAttemptAt에 @Convert(disableConversion = true)를 적용하여 공용 변환기를 비활성화했습니다. DiningReportDeliveryServiceTest는 6자리 소수 초를 포함한 기준 시각을 …
Out of Scope Changes check
변경 범위는 이슈 #2485와 연결된 엔티티 매핑과 회귀 테스트로 제한됩니다. 다른 공용 날짜 변환기, API 형식, 데이터베이스 스키마를 변경하지 않았습니다.
Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 개요
2026-10-11 01:01:53.551000을 읽으면 공용 날짜 변환기에서DateTimeParseException이 발생합니다.🚀 주요 변경 내용
expiresAt과 재시도 시간인nextAttemptAt에@Convert(disableConversion = true)를 적용해 JPA의 기본 날짜 매핑을 사용하도록 합니다.💬 참고 사항
✅ Checklist (완료 조건)
Summary by CodeRabbit