Skip to content

fix: 식단 품절 제보 작업의 시간 변환 오류 수정 - #2486

Merged
taejinn merged 1 commit into
developfrom
fix/2485-dining-delivery-datetime
Oct 10, 2026
Merged

taejinn merged 1 commit into
developfrom
fix/2485-dining-delivery-datetime

Conversation

@taejinn

@taejinn taejinn commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

🔍 개요


🚀 주요 변경 내용

  • 작업 만료 시간인 expiresAt과 재시도 시간인 nextAttemptAt에 @Convert(disableConversion = true)를 적용해 JPA의 기본 날짜 매핑을 사용하도록 합니다.
  • 기존 작업 배정 서비스 테스트에서 소수점이 있는 시간으로 저장과 조회를 검증하고 두 필드의 시간 정밀도가 유지되는지 확인하도록 보완합니다.

💬 참고 사항

  • 두 필드의 매핑만 변경하므로 공용 날짜 변환기 수정이나 DB 마이그레이션은 필요하지 않습니다.
  • 삐봇 API의 요청과 응답 형식은 유지합니다.

✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

  • Bug Fixes
    • Dining report delivery now handles retry and lease-expiration times with fractional-second precision. Failed deliveries retain the expected five-second retry delay, and delivery leases retain the expected 60-second expiration window. This improves the consistency of delivery timing when timestamps include fractions of a second.

@taejinn taejinn added 버그 정상적으로 동작하지 않는 문제상황입니다. 공통 백엔드 공통으로 작업할 이슈입니다. labels Oct 10, 2026
@taejinn taejinn self-assigned this Oct 10, 2026
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 19aef9dc-f41b-4c8a-bffd-834b6a72890b

📥 Commits

Reviewing files that changed from the base of the PR and between 9b5b8da and e939a55.


📒 Files selected for processing (2)
  • src/main/java/in/koreatech/koin/domain/dining/model/DiningReportChange.java
  • src/test/java/in/koreatech/koin/acceptance/domain/DiningReportDeliveryServiceTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The dining report delivery entity disables attribute conversion for expiresAt and nextAttemptAt. Acceptance tests use a fractional-second clock value and verify the five-second retry delay and 60-second lease expiry.

Changes

Dining report delivery timestamps

Layer / File(s) Summary
Timestamp mapping and delivery assertions
src/main/java/in/koreatech/koin/domain/dining/model/DiningReportChange.java, src/test/java/in/koreatech/koin/acceptance/domain/DiningReportDeliveryServiceTest.java
The entity disables attribute conversion for expiresAt and nextAttemptAt. Acceptance tests use a fractional-second start time and verify the expected retry and lease-expiry timestamps.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium


Merge Risk: ⚪ Minimal · up to e939a

The delivery timestamps retain microsecond precision through the database mapping, with no actionable merge risk apparent.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: fixing a time conversion error in sold-out report delivery tasks. It matches the code and test changes.
Linked Issues check Passed 직접 연결된 공개 이슈 #2485의 요구사항을 충족합니다. DiningReportChange.expiresAt 및 nextAttemptAt에 @Convert(disableConversion = true)를 적용하여 공용 변환기를 비활성화했습니다. DiningReportDeliveryServiceTest는 6자리 소수 초를 포함한 기준 시각을 …
Out of Scope Changes check Passed 변경 범위는 이슈 #2485와 연결된 엔티티 매핑과 회귀 테스트로 제한됩니다. 다른 공용 날짜 변환기, API 형식, 데이터베이스 스키마를 변경하지 않았습니다.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR


🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Unit Test Results

   291 files     291 suites   3m 11s ⏱️
1 430 tests 1 427 ✔️ 3 💤 0 ❌
1 438 runs  1 435 ✔️ 3 💤 0 ❌

Results for commit e939a55.

@taejinn
taejinn marked this pull request as ready for review October 10, 2026 17:12
@taejinn
taejinn requested a balanced review from Copilot October 10, 2026 17:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@taejinn
taejinn merged commit 0c3eebc into develop Oct 10, 2026
11 checks passed
@taejinn
taejinn deleted the fix/2485-dining-delivery-datetime branch October 10, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

공통 백엔드 공통으로 작업할 이슈입니다. 버그 정상적으로 동작하지 않는 문제상황입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[공통] 식단 품절 제보 작업 조회 시 시간 변환 오류

3 participants