Skip to content

fix: 팀원 모집 제목과 알림의 공모저온 오타 교정 - #2470

Closed
taejinn wants to merge 1 commit into
developfrom
fix/2469-team-notification-typo
Closed

taejinn wants to merge 1 commit into
developfrom
fix/2469-team-notification-typo

Conversation

@taejinn

@taejinn taejinn commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

🔍 개요


🚀 주요 변경 내용

  • V12__correct_team_recruitment_notification_typo.sql을 추가해 모집글 71번의 제목이 정확히 공모저온인 경우 공모전으로 수정합니다.
  • 알림 136번이 모집글 71번과 지원서 52번에 연결된 APPLICATION_REJECTED, MY_APPLICATIONS 알림이고 기존 문구가 일치하는 경우에만 message_preview를 수정합니다.
    • 예: 지원하신 공모저온 모집이 마감되어 지원이 거절되었어요.를 지원하신 공모전 모집이 마감되어 지원이 거절되었어요.로 변경합니다.
  • MySQL 마이그레이션 테스트에 대상 데이터 교정, 다른 데이터 보존, 조건 불일치 시 수정 제외, 재실행 시 이후 변경한 제목 보존을 검증하는 경우를 추가합니다.

💬 참고 사항

  • 대상 ID나 기존 값이 다르면 해당 데이터는 수정하지 않습니다. 배포 전 모집글 71번의 제목과 알림 136번의 연결 정보 및 원문을 비교하고, 배포 후 GET /team-recruitments/notifications에서 교정된 문구를 다시 확인해야 합니다.

✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

  • Bug Fixes
    • Corrected a spelling error in a team recruitment title and its notification preview. Other titles and notifications remain unchanged unless they match the affected content exactly. This ensures the corrected wording appears consistently wherever the recruitment is shown, including in its notification.

@taejinn taejinn added 버그 정상적으로 동작하지 않는 문제상황입니다. DB DB 마이그레이션을 위한 라벨입니다. labels Oct 4, 2026
@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 34ff55f4-4481-4eb7-8ccd-552e1bf9c7f9
📥 Commits

Reviewing files that changed from the base of the PR and between 6d7c3bd and af35785.

📒 Files selected for processing (2)
  • src/main/resources/db/migration/V12__correct_team_recruitment_notification_typo.sql
  • src/test/java/in/koreatech/koin/acceptance/migration/TeamRecruitmentMigrationTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

A guarded database migration corrects a misspelled recruitment title and the preview of its associated notification. Integration tests verify the updates and confirm that unrelated or non-matching records remain unchanged.

Changes

Recruitment notification typo correction

Layer / File(s) Summary
Guarded correction and migration tests
src/main/resources/db/migration/V12__correct_team_recruitment_notification_typo.sql, src/test/java/in/koreatech/koin/acceptance/migration/TeamRecruitmentMigrationTest.java
The migration corrects the recruitment title and notification preview only when their identifying fields and current values match. Integration tests cover the corrections, unrelated records, edited titles, and notification near-matches.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to af357

No actionable issue is established that would prevent merging the targeted typo correction after normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to af357

The correction is limited to one recruitment and one notification without changing recipients or access permissions. Remaining uncertainty concerns deployment-time recovery and previously stored push-notification text, not a demonstrated security vulnerability.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — Per database where this migration executes, primary keys bound the explicit correction to at most one recruitment row and one notification row. The statements do not change authorship, recipients, application identity, or notification routing fields. Applicability across deployed environments is not established by repository evidence.

Trust Boundaries and Controls

  • observed — The migration uses fixed SQL and replacement strings. Existing stored text determines eligibility through binary comparisons; it is not interpolated into SQL or used to select a new recipient or privileged operation.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Issue [#2469] requires a guarded migration for recruitment 71 and notification 136. V12 changes the recruitment title only when its exact existing title matches. It changes the notification preview on…
Out of Scope Changes check ✅ Passed The migration test additions directly verify the guarded corrections required by issue [#2469]. The diff contains no demonstrated unrelated changes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: correcting the 공모저온 typo in the team recruitment title and notification.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown

Unit Test Results

   285 files     285 suites   2m 37s ⏱️
1 392 tests 1 389 ✔️ 3 💤 0 ❌
1 400 runs  1 397 ✔️ 3 💤 0 ❌

Results for commit af35785.

@taejinn taejinn closed this Oct 4, 2026
@taejinn
taejinn deleted the fix/2469-team-notification-typo branch October 4, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB DB 마이그레이션을 위한 라벨입니다. 버그 정상적으로 동작하지 않는 문제상황입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[백엔드] 팀원 모집 알림의 공모저온 오타 교정

1 participant