Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update workbox-build version #137

Merged
merged 5 commits into from
May 19, 2023
Merged

feat: update workbox-build version #137

merged 5 commits into from
May 19, 2023

Conversation

fvs1981
Copy link
Contributor

@fvs1981 fvs1981 commented Apr 13, 2023

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.90 🎉

Comparison is base (b6200e3) 82.43% compared to head (d3459e8) 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   82.43%   83.33%   +0.90%     
==========================================
  Files           5        5              
  Lines         148      150       +2     
==========================================
+ Hits          122      125       +3     
+ Misses         26       25       -1     
Impacted Files Coverage Δ
addon/instance-initializers/sw.js 87.50% <ø> (ø)
index.js 91.30% <ø> (ø)
lib/broccoli-workbox.js 80.39% <ø> (ø)
addon/services/service-worker.js 79.62% <100.00%> (+2.70%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@svsalvador svsalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the merge checks please. The builds are failing.

tests/acceptance/auto-register-test.js Show resolved Hide resolved
@fvs1981 fvs1981 merged commit 9077294 into master May 19, 2023
@eumendoza
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants