Pretty-print let
s with surrounding braces
#532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pretty-printer for
letseq
andletrec
was not adding braces around the variables being bound, resulting in malformed pretty-printed output such asletseq hw = "Hello, World!";; ...
. After adding braces, this now becomesletseq { hw = "Hello, World!"; };
, which is valid Bluespec code. Fixes #529.In order to add a test case for this fix, I needed to add some machinery to the test suite to run
bsv2bsc
, which exercises the relevant code paths. Along the way, I fixed a bug in thebsc2bsv
machinery (on which thebsv2bsc
machinery is based), so this PR also fixes #531.