Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pipeline to run with Xcode 16 on MacOS 14 #2456

Merged
merged 14 commits into from
Jan 3, 2025
Merged

Conversation

kaisong1990
Copy link
Contributor

Proposed changes

  1. Dublin team skipped some mac e2e tests and still trying to figure our keychain access configuration issue
  2. Resolved MSAL automation failure issue

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

Kai Song and others added 14 commits December 13, 2024 09:33
* Revert macos to 14 and comment

* Proper spacing

* Spacing

* Spacing

* Using Xcode 16.1

* Change simulator to 18.1 for xcode 16.1

* Update simulator

* Correct macos version

---------

Co-authored-by: Silviu Petrescu <[email protected]>
* Skipping e2e tests for macOS that don't work

* Fix macOS version for PR validation script
@kaisong1990 kaisong1990 requested review from a team as code owners December 23, 2024 19:24
@@ -29,6 +29,9 @@ import MSAL
final class MSALNativeAuthSignInWithMFAEndToEndTests: MSALNativeAuthEndToEndPasswordTestCase {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@ameyapat
Copy link
Contributor

Cloned PR for kasong/more-logs


AI description (iteration 1)

PR Classification

Code enhancement and test updates

PR Summary

This pull request enhances the automation pipeline and updates test configurations.

  • Updated automation.yml to include a system information check and updated iOS and macOS test configurations.
  • Modified pr-validation.yml to update iOS and macOS test configurations.
  • Updated MSALNativeAuthSignInWithMFAEndToEndTests.swift to skip certain tests on macOS due to Keychain access issues.
  • Updated MSALNativeAuthSignInUserNameAndPasswordEndToEndTests.swift to skip a test on macOS due to Keychain access issues.
  • Updated tests-with-conf-file.yml to use the latest Xcode version and updated iOS test configurations.

@kaisong1990 kaisong1990 merged commit 4e9c790 into dev Jan 3, 2025
19 of 21 checks passed
@kaisong1990 kaisong1990 deleted the kasong/more-logs branch January 3, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants