Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new error mapping for http error code 403 and 404 #2441

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Add new error mapping for http error code 403 and 404 #2441

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc907c8
Add new error mapping for http error code 403 and 404
Veena11 Dec 18, 2024
209b625
update the error name
Veena11 Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MSAL/IdentityCore
Open in desktop
Submodule IdentityCore updated 5 files
+2 −0 IdentityCore/src/MSIDError.h
+4 −1 IdentityCore/src/MSIDError.m
+7 −1 IdentityCore/src/network/error_handler/MSIDAADRequestErrorHandler.m
+4 −0 IdentityCore/tests/MSIDAADRequestErrorHandlerTests.m
+60 −0 IdentityCore/tests/integration/ios/MSIDDefaultSilentTokenRequestTests.m
3 changes: 2 additions & 1 deletion MSAL/src/MSALErrorConverter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ + (void)initialize
@(MSIDErrorServerError) : @(MSALErrorServerError),
@(MSIDErrorServerInvalidState) : @(MSALInternalErrorInvalidState),
@(MSIDErrorServerProtectionPoliciesRequired) : @(MSALErrorServerProtectionPoliciesRequired),
@(MSIDErrorServerUnhandledResponse) : @(MSALInternalErrorUnhandledResponse)
@(MSIDErrorServerUnhandledResponse) : @(MSALInternalErrorUnhandledResponse),
@(MSIDErrorUnExpectedHttpResponse) : @(MSALInternalErrorUnExpectedHttpResponse)
}
};

Expand Down
6 changes: 6 additions & 0 deletions MSAL/src/public/MSALError.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,11 @@ typedef NS_ENUM(NSInteger, MSALInternalError)
*/
MSALInternalErrorUnexpected = -42008,

/**
Un expected http response with status code 403 or 404
*/
MSALInternalErrorUnExpectedHttpResponse = -42009,

/**
The passed in authority URL does not pass validation.
If you're trying to use B2C, you must disable authority validation by
Expand Down Expand Up @@ -525,4 +530,5 @@ typedef NS_ENUM(NSInteger, MSALInternalError)
JIT - Error Handling config invalid or not found
*/
MSALErrorJITErrorHandlingConfigNotFound = -42738,

};
Loading