IOS Sign Up E2E Test #2422

Yuki-YuXin · 2024-12-12T17:50:22Z

Proposed changes

Modify MSALNativeAuthEndToEndBaseTestCase to use different way of initialization depends on the parameter of customSubdomainFormat
Finish the sign up test cases according to: IOS Test plan

2.1.11 - test_signUpWithCode_withPasswordConfiguration_succeeds()
1.1.10 - test_signUpWithEmailPassword_andAgainSameEmail_fails()
1.1.11 - test_signUpWithEmailPassword_socialAccount_fails() - environment not ready
1.1.12 - test_signUpWithEmailPassword_invalidEmail_fails
1.1.13 - test_signUpWithEmailPassword_invalidPassword_fails
1.1.2 - test_signUpWithEmailPassword_resendEmail_success
1.1.5 - test_signUpWithEmailOTP_andSetPasswordAfterOTP_success
2.1.5 - test_signUpWithEmailOTP_resendEmail_success
2.1.6 - test_signUpWithEmailOTP_andExistingAccount
2.1.7 - test_signUpWithEmailPassword_socialAccount_fails - environment not ready
2.1.8 - test_signUpWithEmailPassword_invalidEmailFormat_fails

Web fallback test to automate:
Verify Custom URL Domain - Sign In
test_signInCustomDomain1InSuccess
test_signInCustomDomain2InSuccess
test_signInCustomDomain3InSuccess

Type of change

Risk

High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

azure-pipelines · 2024-12-12T17:51:05Z

MSAL/test/integration/native_auth/end_to_end/MSALNativeAuthEndToEndBaseTestCase.swift

@@ -37,6 +37,11 @@ class MSALNativeAuthEndToEndBaseTestCase: XCTestCase {
        static let signInEmailPasswordMFAUsernameKey = "sign_in_email_password_mfa_username"


This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

ameyapat · 2024-12-12T17:58:29Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling custom domain formats and error conditions.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account checks, invalid email formats, and password configurations.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid password complexity.
MSALNativeAuthSignInUserNameAndPasswordEndToEndTests.swift: Added tests for custom domain sign-in scenarios.
MSALNativeAuthEndToEndBaseTestCase.swift: Updated to support custom subdomain formats and added helper methods for custom tenant subdomains.

ameyapat · 2024-12-12T18:15:04Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling of email OTP, password complexity, and custom domain formats.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account checks, and invalid email formats.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including invalid email/password formats and OTP resend.
MSALNativeAuthSignInUserNameAndPasswordEndToEndTests.swift: Added tests for sign-in with custom URL domains.
MSALNativeAuthEndToEndBaseTestCase.swift: Updated client application initialization to support custom subdomain formats.

nilo-ms · 2024-12-19T15:41:38Z

MSAL/test/integration/native_auth/end_to_end/MSALNativeAuthEndToEndBaseTestCase.swift

@@ -129,4 +171,15 @@ class MSALNativeAuthEndToEndBaseTestCase: XCTestCase {
            return Constants.clientIdEmailCodeAttributesKey
        }
    }
+
+    private func getCustomTenantSubdomain(tenantName: String, tenantId: String, format: AuthorityURLFormat) -> String {


Could you please call this method getAuthotityURLString ? It seems more accurate.

Suggested change

private func getCustomTenantSubdomain(tenantName: String, tenantId: String, format: AuthorityURLFormat) -> String {

private func getAuthotityURLString(tenantSubdomain: String, tenantId: String, format: AuthorityURLFormat) -> String {

And could you please use tenantSubdomain instead of tenantName. They are two different properties

nilo-ms · 2024-12-19T15:43:11Z

...t/integration/native_auth/end_to_end/sign_in/MSALNativeAuthSignInUsernameEndToEndTests.swift

@@ -125,4 +125,130 @@ final class MSALNativeAuthSignInUsernameEndToEndTests: MSALNativeAuthEndToEndBas
        XCTAssertNotNil(signInVerifyCodeDelegateSpy.result?.idToken)
        XCTAssertEqual(signInVerifyCodeDelegateSpy.result?.account.username, username)
    }
+
+    // Sign In - Verify Custom URL Domain - "https://<tenantName>.ciamlogin.com/<tenantName>.onmicrosoft.com"
+    func test_signInCustomDomain1InSuccess() async throws {


Can you please include the name of the authority URL format in use instead of a number? Same comment applies for other tests

nilo-ms · 2024-12-19T15:47:46Z

...on/native_auth/end_to_end/sign_up/MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift

+
+        // Verify error condition
+        XCTAssertTrue(signUpStartDelegate.onSignUpPasswordErrorCalled)
+        XCTAssertEqual(signUpStartDelegate.error!.isInvalidUsername, true)


Try to never use ! to force unwrap an optional. This can cause a crash and stop the execution of all tests

Suggested change

XCTAssertEqual(signUpStartDelegate.error!.isInvalidUsername, true)

XCTAssertEqual(signUpStartDelegate.error?.isInvalidUsername, true)

Good point. Done and modify and check all the sign up cases. error!.isBrowserRequired needs to use ! instead of ?. The others use ?.

nilo-ms · 2024-12-19T15:48:35Z

...on/native_auth/end_to_end/sign_up/MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift

+
+        // Verify error condition
+        XCTAssertTrue(signUpStartDelegate.onSignUpPasswordErrorCalled)
+        XCTAssertEqual(signUpStartDelegate.error!.isInvalidUsername, true)


Suggested change

XCTAssertEqual(signUpStartDelegate.error!.isInvalidUsername, true)

XCTAssertEqual(signUpStartDelegate.error?.isInvalidUsername, true)

nilo-ms · 2024-12-19T15:48:48Z

...on/native_auth/end_to_end/sign_up/MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift

+
+        // Verify error condition
+        XCTAssertTrue(signUpStartDelegate.onSignUpPasswordErrorCalled)
+        XCTAssertEqual(signUpStartDelegate.error!.isInvalidPassword, true)


Suggested change

XCTAssertEqual(signUpStartDelegate.error!.isInvalidPassword, true)

XCTAssertEqual(signUpStartDelegate.error?.isInvalidPassword, true)

nilo-ms · 2024-12-19T15:49:08Z

...t/integration/native_auth/end_to_end/sign_up/MSALNativeAuthSignUpUsernameEndToEndTests.swift

+
+        // Verify error condition
+        XCTAssertTrue(signUpStartDelegate.onSignUpErrorCalled)
+        XCTAssertEqual(signUpStartDelegate.error!.isUserAlreadyExists, true)


Suggested change

XCTAssertEqual(signUpStartDelegate.error!.isUserAlreadyExists, true)

XCTAssertEqual(signUpStartDelegate.error?.isUserAlreadyExists, true)

nilo-ms · 2024-12-19T15:49:20Z

...t/integration/native_auth/end_to_end/sign_up/MSALNativeAuthSignUpUsernameEndToEndTests.swift

+
+        // Verify error condition
+        XCTAssertTrue(signUpStartDelegate.onSignUpPasswordErrorCalled)
+        XCTAssertEqual(signUpStartDelegate.error!.isInvalidUsername, true)


Suggested change

XCTAssertEqual(signUpStartDelegate.error!.isInvalidUsername, true)

XCTAssertEqual(signUpStartDelegate.error?.isInvalidUsername, true)

nilo-ms · 2024-12-19T15:49:28Z

...t/integration/native_auth/end_to_end/sign_up/MSALNativeAuthSignUpUsernameEndToEndTests.swift

+
+        // Verify error condition
+        XCTAssertTrue(signUpStartDelegate.onSignUpPasswordErrorCalled)
+        XCTAssertEqual(signUpStartDelegate.error!.isInvalidUsername, true)


Suggested change

XCTAssertEqual(signUpStartDelegate.error!.isInvalidUsername, true)

XCTAssertEqual(signUpStartDelegate.error?.isInvalidUsername, true)

nilo-ms · 2024-12-19T15:50:49Z

...t/integration/native_auth/end_to_end/sign_in/MSALNativeAuthSignInUsernameEndToEndTests.swift

+
+    // Sign In - Verify Custom URL Domain - "https://<tenantName>.ciamlogin.com/<tenantName>.onmicrosoft.com"
+    func test_signInCustomDomain1InSuccess() async throws {
+        guard let sut = initialisePublicClientApplication(clientIdType: .code, customAuthorityURLFormat: AuthorityURLFormat.tenantSubdomainLongVersion), let username = retrieveUsernameForSignInCode() else {


nit: you can avoid specifying the Enum name here :)

Suggested change

guard let sut = initialisePublicClientApplication(clientIdType: .code, customAuthorityURLFormat: AuthorityURLFormat.tenantSubdomainLongVersion), let username = retrieveUsernameForSignInCode() else {

guard let sut = initialisePublicClientApplication(clientIdType: .code, customAuthorityURLFormat: .tenantSubdomainLongVersion), let username = retrieveUsernameForSignInCode() else {

nilo-ms · 2024-12-19T15:54:20Z

...t/integration/native_auth/end_to_end/sign_up/MSALNativeAuthSignUpUsernameEndToEndTests.swift

+    }
+
+    // Hero Scenario 2.1.11. Sign up – Server requires password authentication, which is supported by the developer
+    // The same as 1.1.4


If it is the same as the 1.1.4 why we're duplicating this test?

Repeat confirmation on the duplication. I will remove the test case but keep the comment for future tracking.

ameyapat · 2024-12-19T16:50:11Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios in the MSAL Native Auth module.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account checks, invalid email format, and unsupported password authentication.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for custom URL domain sign-in scenarios.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios including resend OTP, invalid email/password, and existing account checks.
MSALNativeAuthEndToEndBaseTestCase.swift: Updated initialisePublicClientApplication to support custom authority URL formats.

ameyapat · 2024-12-19T17:03:11Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end test cases for sign-up and sign-in functionalities, including various edge cases and custom URL domain verifications.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account scenarios, invalid email formats, and unsupported authentication challenges.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for sign-in with custom URL domains.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid credentials.
MSALNativeAuthEndToEndBaseTestCase.swift: Enhanced client application initialization to support custom authority URL formats.

…by the Kevault component

ameyapat · 2024-12-20T10:32:37Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling of custom URL domains and error conditions.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account errors, invalid email formats, and unsupported password authentication.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for sign-in with custom URL domains.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid password complexity.
MSALNativeAuthEndToEndBaseTestCase.swift: Updated initialisePublicClientApplication to support custom authority URL formats.

…equired by the Kevault component" This reverts commit d239b4c.

This reverts commit 1c93d83.

ameyapat · 2024-12-20T11:11:50Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling of email OTP, password complexity, and custom URL domains.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account errors, and invalid email formats.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for sign-in with custom URL domains.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid password complexity.
MSALNativeAuthEndToEndBaseTestCase.swift: Updated client application initialization to support custom authority URL formats.

ameyapat · 2024-12-20T11:18:51Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling of email OTP, password complexity, and custom URL domains.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account errors, and invalid email formats.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for custom URL domain sign-in scenarios.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid password complexity.
MSALNativeAuthEndToEndBaseTestCase.swift: Updated client application initialization to support custom authority URL formats.

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling of email OTP, password complexity, and custom URL domains.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account errors, and invalid email formats.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for sign-in with custom URL domains.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid password complexity.
MSALNativeAuthEndToEndBaseTestCase.swift: Enhanced client application initialization to support custom authority URL formats.

ameyapat · 2024-12-20T11:19:49Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling of email OTP, password complexity, and custom URL domains.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account errors, and invalid email formats.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for custom URL domain sign-in scenarios.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid password complexity.
MSALNativeAuthEndToEndBaseTestCase.swift: Updated client application initialization to support custom authority URL formats.

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling of email OTP, password complexity, and custom URL domains.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account errors, and invalid email formats.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for sign-in with custom URL domains.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid password complexity.
MSALNativeAuthEndToEndBaseTestCase.swift: Enhanced client application initialization to support custom authority URL formats.

…tion-library-for-objc into yuki/sign-up-e2e

ameyapat · 2024-12-25T18:47:42Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling custom URL domains and error conditions.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account errors, invalid email formats, and unsupported password authentication.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for sign-in with custom URL domains.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid password complexity.
MSALNativeAuthEndToEndBaseTestCase.swift: Updated initialisePublicClientApplication to support custom authority URL formats.

…tion-library-for-objc into yuki/sign-up-e2e

ameyapat · 2025-01-03T20:47:17Z

Cloned PR for yuki/sign-up-e2e

AI description (iteration 1)

PR Classification

New feature

PR Summary

This pull request adds new end-to-end tests for various sign-up and sign-in scenarios, including handling of email OTP, password complexity, and custom URL domains.

MSALNativeAuthSignUpUsernameEndToEndTests.swift: Added tests for email OTP resend, existing account errors, and invalid email formats.
MSALNativeAuthSignInUsernameEndToEndTests.swift: Added tests for sign-in with custom URL domains.
MSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.swift: Added tests for email and password sign-up scenarios, including OTP resend and invalid password complexity.
MSALNativeAuthEndToEndBaseTestCase.swift: Updated client application initialization to support custom authority URL formats.

Yuki-YuXin added 24 commits December 11, 2024 09:25

1.1.10 & 1.1.12

2565b80

2.1.11

3247d2a

1.1.13

fd3a63a

1.1.2

a469024

1.1.5

9974b64

2.1.10

578c479

2.1.10 move to the right place

24e6838

2.1.5

2bf3f9e

2.1.6

e90dadc

2.1.7&2.1.8

94b550b

pass 2.1.11

db431c4

1.1.10 pass

9cd2c77

1.1.11 pass

b197a17

1.1.12 pass

95bfcaf

1.1.13 pass

b7e826d

1.1.2 pass

dc67b95

1.1.5 pass

91e59f0

2.1.10 pass + use correct error message

c2ff7f7

2.1.5 pass

273af9b

2.1.6 pass

e163297

2.1.7 pass

4ab385a

2.1.8 pass

08ba0c8

remove correlation id one because it's out of scope

61569bb

Verify Custom URL Domain - Sign In

faa59c5

Yuki-YuXin requested a review from a team as a code owner December 12, 2024 17:50

Yuki-YuXin added the native-auth Code related to native authentication label Dec 12, 2024

azure-pipelines bot reviewed Dec 12, 2024

View reviewed changes

add signInCustomDomain2InSuccess and skip

886d1fe

Yuki-YuXin removed the skip-native-auth-e2e-tests Only include this if Native Auth E2E tests are blocking the PR validation label Dec 18, 2024

nilo-ms reviewed Dec 19, 2024

View reviewed changes

Address comments

7fe3bc8

Pass the local test

1422d14

nilo-ms approved these changes Dec 19, 2024

View reviewed changes

spetrescu84 approved these changes Dec 20, 2024

View reviewed changes

Skipping failing E2E tests for macOS due to Keychain access required …

d239b4c

…by the Kevault component

spetrescu84 added 3 commits December 20, 2024 11:02

Revert "Skipping failing E2E tests for macOS due to Keychain access r…

4f65bff

…equired by the Kevault component" This reverts commit d239b4c.

Switch PR validation to proper macOS version

1c93d83

Revert "Switch PR validation to proper macOS version"

96c3908

This reverts commit 1c93d83.

Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…

08ef259

…tion-library-for-objc into yuki/sign-up-e2e

Merge branch 'dev' of https://github.com/AzureAD/microsoft-authentica…

6704e4c

…tion-library-for-objc into yuki/sign-up-e2e

Yuki-YuXin merged commit 04cab7c into dev Jan 3, 2025
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IOS Sign Up E2E Test #2422

IOS Sign Up E2E Test #2422

Yuki-YuXin commented Dec 12, 2024 •

edited

Loading

azure-pipelines bot Dec 12, 2024

ameyapat commented Dec 12, 2024

ameyapat commented Dec 12, 2024

nilo-ms Dec 19, 2024

Yuki-YuXin Dec 19, 2024

nilo-ms Dec 19, 2024 •

edited

Loading

Yuki-YuXin Dec 19, 2024

nilo-ms Dec 19, 2024 •

edited

Loading

Yuki-YuXin Dec 19, 2024

nilo-ms Dec 19, 2024

Yuki-YuXin Dec 19, 2024

nilo-ms Dec 19, 2024

Yuki-YuXin Dec 19, 2024

nilo-ms Dec 19, 2024

Yuki-YuXin Dec 19, 2024

nilo-ms Dec 19, 2024

Yuki-YuXin Dec 19, 2024

nilo-ms Dec 19, 2024

Yuki-YuXin Dec 19, 2024

nilo-ms Dec 19, 2024

Yuki-YuXin Dec 19, 2024

nilo-ms Dec 19, 2024

Yuki-YuXin Dec 19, 2024

ameyapat commented Dec 19, 2024

ameyapat commented Dec 19, 2024

ameyapat commented Dec 20, 2024

ameyapat commented Dec 20, 2024

ameyapat commented Dec 20, 2024

ameyapat commented Dec 20, 2024

ameyapat commented Dec 25, 2024

ameyapat commented Jan 3, 2025

		@@ -37,6 +37,11 @@ class MSALNativeAuthEndToEndBaseTestCase: XCTestCase {
		static let signInEmailPasswordMFAUsernameKey = "sign_in_email_password_mfa_username"

	private func getCustomTenantSubdomain(tenantName: String, tenantId: String, format: AuthorityURLFormat) -> String {
	private func getAuthotityURLString(tenantSubdomain: String, tenantId: String, format: AuthorityURLFormat) -> String {

	XCTAssertEqual(signUpStartDelegate.error!.isInvalidUsername, true)
	XCTAssertEqual(signUpStartDelegate.error?.isInvalidUsername, true)

	guard let sut = initialisePublicClientApplication(clientIdType: .code, customAuthorityURLFormat: AuthorityURLFormat.tenantSubdomainLongVersion), let username = retrieveUsernameForSignInCode() else {
	guard let sut = initialisePublicClientApplication(clientIdType: .code, customAuthorityURLFormat: .tenantSubdomainLongVersion), let username = retrieveUsernameForSignInCode() else {

IOS Sign Up E2E Test #2422

IOS Sign Up E2E Test #2422

Conversation

Yuki-YuXin commented Dec 12, 2024 • edited Loading

Proposed changes

Type of change

Risk

azure-pipelines bot Dec 12, 2024

Choose a reason for hiding this comment

ameyapat commented Dec 12, 2024

AI description (iteration 1)

PR Classification

PR Summary

ameyapat commented Dec 12, 2024

AI description (iteration 1)

PR Classification

PR Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nilo-ms Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nilo-ms Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ameyapat commented Dec 19, 2024

AI description (iteration 1)

PR Classification

PR Summary

ameyapat commented Dec 19, 2024

AI description (iteration 1)

PR Classification

PR Summary

ameyapat commented Dec 20, 2024

AI description (iteration 1)

PR Classification

PR Summary

ameyapat commented Dec 20, 2024

AI description (iteration 1)

PR Classification

PR Summary

ameyapat commented Dec 20, 2024

AI description (iteration 1)

PR Classification

PR Summary

AI description (iteration 1)

PR Classification

PR Summary

ameyapat commented Dec 20, 2024

AI description (iteration 1)

PR Classification

PR Summary

AI description (iteration 1)

PR Classification

PR Summary

ameyapat commented Dec 25, 2024

AI description (iteration 1)

PR Classification

PR Summary

ameyapat commented Jan 3, 2025

AI description (iteration 1)

PR Classification

PR Summary

Yuki-YuXin commented Dec 12, 2024 •

edited

Loading

nilo-ms Dec 19, 2024 •

edited

Loading

nilo-ms Dec 19, 2024 •

edited

Loading