Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run build script phase only when needed #2218

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

nilo-ms
Copy link
Contributor

@nilo-ms nilo-ms commented Jun 21, 2024

Proposed changes

Run build script phase only when needed. This PR solve the following warning:
Screenshot 2024-06-21 at 16 48 38
I'm using this as a reference:
https://developer.apple.com/documentation/Xcode/improving-the-speed-of-incremental-builds#Declare-inputs-and-outputs-for-custom-scripts-and-build-rules

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

@nilo-ms nilo-ms requested review from a team as code owners June 21, 2024 16:04
@nilo-ms nilo-ms merged commit 68b97f3 into dev Jun 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants