Add new error mapping for http error code 403 and 404

AzureAD · Dec 18, 2024 · bc907c8 · bc907c8
1 parent 1d64572
commit bc907c8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/MSAL/IdentityCore b/MSAL/IdentityCore
diff --git a/MSAL/src/MSALErrorConverter.m b/MSAL/src/MSALErrorConverter.m
@@ -130,7 +130,8 @@ + (void)initialize
                                    @(MSIDErrorServerError) : @(MSALErrorServerError),
                                    @(MSIDErrorServerInvalidState) : @(MSALInternalErrorInvalidState),
                                    @(MSIDErrorServerProtectionPoliciesRequired) : @(MSALErrorServerProtectionPoliciesRequired),
-                                   @(MSIDErrorServerUnhandledResponse) : @(MSALInternalErrorUnhandledResponse)
+                                   @(MSIDErrorServerUnhandledResponse) : @(MSALInternalErrorUnhandledResponse),
+                                   @(MSIDErrorUnExpectedHttpResponse) : @(MSALInternalErrorUnExpectedHttpResponse)
                                    }
                            };
 

diff --git a/MSAL/src/public/MSALError.h b/MSAL/src/public/MSALError.h
@@ -262,6 +262,11 @@ typedef NS_ENUM(NSInteger, MSALInternalError)
      */
     MSALInternalErrorUnexpected                         = -42008,
 
+    /**
+     Un expected http response with status code 403 or 404
+     */
+    MSALInternalErrorUnExpectedHttpResponse             = -42009,
+
     /**
      The passed in authority URL does not pass validation.
      If you're trying to use B2C, you must disable authority validation by
@@ -525,4 +530,5 @@ typedef NS_ENUM(NSInteger, MSALInternalError)
      JIT - Error Handling config invalid or not found
      */
     MSALErrorJITErrorHandlingConfigNotFound             = -42738,
+
 };
+2 −0		IdentityCore/src/MSIDError.h
+4 −1		IdentityCore/src/MSIDError.m
+7 −1		IdentityCore/src/network/error_handler/MSIDAADRequestErrorHandler.m
+4 −0		IdentityCore/tests/MSIDAADRequestErrorHandlerTests.m
+60 −0		IdentityCore/tests/integration/ios/MSIDDefaultSilentTokenRequestTests.m