Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in management_ip_configuration #79

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

SvenAelterman
Copy link
Contributor

@SvenAelterman SvenAelterman commented Jul 21, 2024

Describe your changes

Fix management_ip_coniguration to management_ip_configuration so that zones, ip_version, and sku_tier are correctly processed.

Issue number

#78

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@SvenAelterman
Copy link
Contributor Author

I realize the prepr-check fails, but I didn't touch those lines of code. If required, I can try to see if I can change the use of the lookup to be compliant with the check.

@matt-FFFFFF matt-FFFFFF merged commit 205d562 into Azure:main Jul 22, 2024
1 of 3 checks passed
@matt-FFFFFF
Copy link
Member

Thanks for the PR!

@SvenAelterman
Copy link
Contributor Author

@matt-FFFFFF When will a new version with this fix be released?

@cpinotossi
Copy link

Did verify .terraform\modules\hubnetworking\locals.tf and the typo still exist:

fw_management_ip_configuration_pip = {
for k, v in var.hub_virtual_networks : k => {
location = local.virtual_networks_modules[k].vnet_location
name = try(v.firewall.management_ip_configuration.public_ip_config.name, "pip-afw-mgmt-${k}")
resource_group_name = v.resource_group_name
ip_version = try(v.firewall.management_ip_coniguration.public_ip_config.ip_version, "IPv4")
sku_tier = try(v.firewall.management_ip_coniguration.public_ip_config.sku_tier, "Regional")
zones = try(v.firewall.management_ip_coniguration.public_ip_config.zones, null)
} if try(v.firewall.sku_tier, "FirewallNull") == "Basic" && v.firewall != null
}

Would be great if somebody could fix this typo so I can deploy an Basic FW.

@SvenAelterman
Copy link
Contributor Author

@matt-FFFFFF Can you check into this again, please? Seems like the PR content was somehow reversed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants