Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update node to 18 in dockerfile #755

Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix: update node to 18 in dockerfile #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b46da82
fix: update node to 18 in dockerfile
Oct 19, 2023
2fdb1af
fix the version of npm to 10
Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ FROM mcr.microsoft.com/azure-functions/python:4-python3.9-core-tools
COPY library-scripts/*.sh library-scripts/*.env /tmp/library-scripts/

# Install Node.js, Azure Static Web Apps CLI and Azure Functions Core Tools
ARG NODE_VERSION="16"
ARG NODE_VERSION="18"
ARG NPM_VERSION="10"
ARG CORE_TOOLS_VERSION="4"
ARG USERNAME="swa-cli"
ARG SWA_CLI_VERSION
Expand All @@ -27,7 +28,7 @@ RUN bash /tmp/library-scripts/node-debian.sh "${NVM_DIR}" "${NODE_VERSION}" "${U
&& if [ $CORE_TOOLS_VERSION != "4" ]; then apt-get remove -y azure-functions-core-tools-4 && apt-get install -y "azure-functions-core-tools-${CORE_TOOLS_VERSION}"; fi \
&& apt-get clean -y && rm -rf /var/lib/apt/lists/*

RUN su swa-cli -c "umask 0002 && npm install --cache /tmp/empty-cache -g npm@latest fuzz-run" \
RUN su swa-cli -c "umask 0002 && npm install --cache /tmp/empty-cache -g npm@$NPM_VERSION fuzz-run" \
&& if [ -n "$SWA_CLI_VERSION" ]; then su swa-cli -c "umask 0002 && npm install --cache /tmp/empty-cache -g @azure/static-web-apps-cli@$SWA_CLI_VERSION"; fi

USER swa-cli
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"args": {
// Please look at runtime version support to make sure you're using compatible versions
// https://docs.microsoft.com/en-us/azure/azure-functions/supported-languages#languages-by-runtime-version
"NODE_VERSION": "16",
"NODE_VERSION": "18",
"CORE_TOOLS_VERSION": "4"
}
},
Expand Down