Open
Conversation
hdwhdw
force-pushed
the
feature/bypass-validation
branch
from
0f4e70f to
1541c48
Compare
Design doc for direct ConfigDB write bypass feature: - Triggered via gRPC metadata header x-sonic-ss-bypass-validation - Gated by SKU check and table allowlist - Reduces GNMI Set latency from ~6s to ~20ms Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
hdwhdw
force-pushed
the
feature/bypass-validation
branch
from
1541c48 to
3758720
Compare
Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
| ### Trigger Mechanism | ||
| Per-request gRPC metadata header (consistent with DPU proxy pattern): | ||
| ``` | ||
| x-sonic-ss-bypass-validation: true |
There was a problem hiding this comment.
Can you confirm how does the AzD request being made?
Author
There was a problem hiding this comment.
Yes. The example he gave is gnmi_set, but those doesn't matter. As long as all speaks gnmi protocol we are good. This is just an exmaple.
| With bypass: | ||
| ```go | ||
| if c.origin == "sonic-db" { | ||
| if shouldBypassValidation(ctx) && checkSKU() && isAllowedTable(table) { |
Author
There was a problem hiding this comment.
I just checked the meeting and we agree to restrict the scope for cisco smartswitch
|
|
||
| ### Metadata Extraction (following DPU proxy pattern) | ||
| ```go | ||
| func shouldBypassValidation(ctx context.Context) bool { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design doc for direct ConfigDB write bypass feature:
Why I did it
How I did it
(SHOW command specific) What sources are you using to fetch data?
How to verify it (Please provide snapshot of diff coverage from CI pipeline)
(Show command specific) Output of show CLI that is equivalent to API output
Manual test output of API on device (Please provide output from device that you have tested your changes on)
A picture of a cute animal (not mandatory but encouraged)