Added 7 Graph queries to APIM checklist #914
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 7 Graph queries to APIM checklist
andredewes
reviewed
Sep 20, 2024
There was a problem hiding this comment.
@seenu433 Shouldn't it be better for the recommendations that are only available in Premium instances that ARG queries filter only for sku == Premium?
For example, for customers that have Developer/Basic/Standard tiers they will be flagged in the recommendations about multi regional and AZ even though that's not possible.
|
@andredewes - Unlike Advisor recommendations (for blast radius reasons), I would rather flag all instances in scope against compliance as we do not know the criticality of the workload. |
|
You probably need to use single quotes in the ARG queries, otherwise the JSON is not valid |
erjosito
requested changes
Sep 26, 2024
|
@erjosito -comments addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 7 Graph queries to APIM checklist