Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing Delivery feedback from the field - ALZ #501

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Addressing Delivery feedback from the field - ALZ #501

merged 8 commits into from
Sep 28, 2023

Conversation

tsc-buddy
Copy link
Contributor

Things addressed in this PR are as follows:

  • Put the design areas in the correct order, both within the JSON and via new ID Column
  • Address a number of Typos and wording issues
  • Sorted the management sub category IDs out
  • Renamed AAD to Microsoft Entra ID

@tsc-buddy tsc-buddy requested review from a team as code owners September 27, 2023 00:31
igorjnzl
igorjnzl reviewed Sep 27, 2023
View reviewed changes
checklists/alz_checklist.en.json Outdated Show resolved Hide resolved
checklists/alz_checklist.en.json Outdated Show resolved Hide resolved
checklists/alz_checklist.en.json Outdated Show resolved Hide resolved
checklists/alz_checklist.en.json Show resolved Hide resolved
checklists/alz_checklist.en.json Outdated Show resolved Hide resolved
checklists/alz_checklist.en.json Outdated Show resolved Hide resolved
igorjnzl
igorjnzl approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@igorjnzl igorjnzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all feedback resolved

@igorjnzl igorjnzl merged commit c4c7dba into Azure:main Sep 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brsteph brsteph brsteph left review comments

@igorjnzl igorjnzl igorjnzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsc-buddy @igorjnzl @brsteph