Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major review of AVD checklist #450

Merged
merged 24 commits into from
Jul 14, 2023
Merged

Major review of AVD checklist #450

merged 24 commits into from
Jul 14, 2023

Conversation

igorpag
Copy link
Member

@igorpag igorpag commented Jul 9, 2023

No description provided.

Copy link
Collaborator

@bagwyth bagwyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I had a few minor suggestions you could look at but nothing major.

checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
Copy link

@jensheerin jensheerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 inline suggestions

checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
@igorpag
Copy link
Member Author

igorpag commented Jul 11, 2023

Thanks @brmoreir for your comments, I have just updated this PR. May I ask you to now formally submit your review here? Thanks.

Copy link
Collaborator

@MikeBazMSFT MikeBazMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nice setup overall!

checklists/avd_checklist.en.json Show resolved Hide resolved
checklists/avd_checklist.en.json Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
Copy link
Contributor

@yamorish yamorish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added and edited few items. Please review these and discuss whether it is worth adding these items to the list.

checklists/avd_checklist.en.json Show resolved Hide resolved
checklists/avd_checklist.en.json Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Outdated Show resolved Hide resolved
checklists/avd_checklist.en.json Show resolved Hide resolved
checklists/avd_checklist.en.json Show resolved Hide resolved
checklists/avd_checklist.en.json Show resolved Hide resolved
@igorpag
Copy link
Member Author

igorpag commented Jul 13, 2023

#pr-ready

Copy link
Collaborator

@mikewarr mikewarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving!

@mikewarr mikewarr merged commit 812f430 into Azure:main Jul 14, 2023
2 checks passed
@igorpag
Copy link
Member Author

igorpag commented Jul 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants