-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major review of AVD checklist #450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I had a few minor suggestions you could look at but nothing major.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 inline suggestions
Thanks @brmoreir for your comments, I have just updated this PR. May I ask you to now formally submit your review here? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a nice setup overall!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added and edited few items. Please review these and discuss whether it is worth adding these items to the list.
#pr-ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving!
[heart] Igor Pagliai reacted to your message:
…________________________________
From: Mike Warrington ***@***.***>
Sent: Friday, July 14, 2023 9:00:52 AM
To: Azure/review-checklists ***@***.***>
Cc: Igor Pagliai ***@***.***>; Author ***@***.***>
Subject: Re: [Azure/review-checklists] Major review of AVD checklist (PR #450)
@mikewarr approved this pull request.
Approving!
—
Reply to this email directly, view it on GitHub<#450 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADEK4ZGRTCFJTOSLVDDILRLXQEDEJANCNFSM6AAAAAA2DLVHIM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
No description provided.