fix: raid array not persistent after upgrade/reboot #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmclong
force-pushed
the
dev/jlong/fixraid
branch
from
5fc62c7 to
4c4923f
Compare
jmclong
force-pushed
the
dev/jlong/fixraid
branch
from
4c4923f to
f26f23d
Compare
jmclong
requested review from
a team,
croomes and
landreasyan
as code owners
croomes
approved these changes
Dec 16, 2025
Comment on lines
+89
to
+99
| RAID_DEVICE="/dev/md0" | ||
| if ! mdadm --create "${RAID_DEVICE}" \ | ||
| --name="${RAID_NAME}" \ | ||
| --level=0 \ | ||
| --raid-devices="${#UNUSED_DEVICES[@]}" \ | ||
| "${UNUSED_DEVICES[@]}" \ | ||
| --run \ | ||
| --force; then | ||
| echo "Error: Failed to create RAID array." | ||
| exit 1 | ||
| fi |
Collaborator
There was a problem hiding this comment.
It's possible to get here if /dev/md0 already exists but doesn't match our $RAID_NAME. The create should fail, which is ok. I don't think we need to support nodes with multiple raid groups (yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the RAID setup process in the Helm chart, making mdadm-based RAID configuration more robust and modular. The RAID initialization logic has been refactored into a dedicated script, and documentation has been updated to clarify the differences between LVM RAID and mdadm-based RAID. Additionally, there are updates to pre-commit hooks, minor script improvements, and new deployment parameters.
RAID Setup Improvements:
charts/latest/scripts/setup-raid.sh, which now handles detection, creation, and validation of RAID and LVM volume groups in a modular and robust way. This script supports both single and multiple NVMe device scenarios and ensures idempotency. (charts/latest/scripts/setup-raid.sh)VOLUME_GROUPas an environment variable for flexibility. (charts/latest/templates/daemonset.yaml) [1] [2]charts/latest/README.md,charts/latest/values.yaml, anddocs/user-guide.mdto clarify the differences between LVM RAID and mdadm-based RAID, highlight the experimental status of mdadm RAID, and warn about migration limitations. [1] [2] [3] [4]Tooling and Automation:
.pre-commit-config.yamland updated several tool versions for improved linting and code quality. [1] [2] [3]Deployment and Script Enhancements:
deploy/parameters/nvme-v4-ubuntu.json)deploy/scripts/arc-install.sh,deploy/scripts/arc-uninstall.sh) [1] [2]hack/add_copyright.shand usingread -rpfor better user prompts inhack/cleanup_leaked_resources.sh. [1] [2]Documentation:
README.md,SECURITY.md, anddocs/design/webhooks.md. [1] [2] [3]Fixes #302