-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pre-PR]add h100 on gpu sku #553
base: main
Are you sure you want to change the base?
Conversation
@HakjunMIN please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Pull Request Test Coverage Report for Build 11567324472Details
💛 - Coveralls |
Not sure |
Did you validate it with an h100? Can you show some screenshots of it joining the cluster? |
@Bryce-Soghigian Of course NOT. This is Pre-PR. I'm not sure the code that I changed is enough so I'm asking you to review Please check code itself first. |
Yes it looks right, that list is used to determine which skus we allow as gpu skus, so this should do the trick. |
@Bryce-Soghigian Got it. I should share the result with you after testing on H100. I'll use |
You can't use those stages, you shuld use the make commands to test it locally. Use make az-all |
Okay. Thank you! |
@Bryce-Soghigian Hey, during validation on the cluseter an error is happening like #579. I',m just suspecting the image version of Ubunt image because similar error is happened in other Korea company. However found #531 which image version was deleted in nodeclass. Could you look through this bug? |
Fixes #517
Description
Make Karpenter provision H100 node
How was this change tested?
Not yet. This pre-PR is for @Bryce-Soghigian to validate code itself prior to apply the cluster where h100 is available at.
*
Does this change impact docs?
Release Note