Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add auxiliary token policy and update VMsClient to use in client options #540

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rakechill
Copy link
Contributor

Description
This PR adds:

  • GetAuxiliaryToken() which will return a token that can authenticate with shared node image galleries for managed Karpenter users.
  • AuxiliaryTokenPolicy which provides a policy to add an auxiliary token to a request
  • Updates VirtualMachinesClient to use this policy in its opts

How was this change tested?

  • [WIP] e2e testing environment with msi-connector dependency
  • TODO: unit tests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@coveralls
Copy link

coveralls commented Oct 24, 2024

Pull Request Test Coverage Report for Build 11509167009

Details

  • 0 of 54 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 97.44%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/auth/policy.go 0 7 0.0%
pkg/providers/instance/azure_client.go 0 19 0.0%
pkg/auth/cred.go 0 28 0.0%
Totals Coverage Status
Change from base Build 11508710261: -0.1%
Covered Lines: 36994
Relevant Lines: 37966

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants