-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Open Telemetry #2449
base: main
Are you sure you want to change the base?
Conversation
Thanks @tommasodotNET for taking up this feature. Added few comments. Also,
|
Hi @abhishekkumams. I've added some tests for the CLI. As for actual testing I have no idea at the moment. We would need an OTEL endpoint... |
/azp run |
@tommasodotNET , there are some formatting errors in your PR. you can run |
Before we can merge, we need to ensure we have a custom Configuration changeThis setting is obeyed regardless of {
"runtime": {
"telemetry": {
"open-telemetry": {
"include-sensitive-data": <boolean, default: false>
}
}
}
} Activity lineage
1. EntityOp (Activity)Tags:
1.1 Request (Event)Tags:
1.2 PreDatabase (Activity)The reason this is an activity is to allow for potential future Script events for pre-database operations, such as validation or transformation. Tags:
1.2.1 Script (Event)Tags:
1.3 Database (Event)Tags:
1.4 PostDatabase (Activity)The reason this is an activity is to allow for potential future Script events for post-database processing, such as data enrichment or aggregation. Tags:
1.4.1 Script (Event)Tags:
1.5 Response (Event)Tags:
The Script (Event) entries are placeholders for future implementations. Including them now highlights why PreDatabase and PostDatabase are designed as activities—they can group and manage multiple scripts when implemented later. |
Few Things:
|
/azp run |
Why make this change?
Initial implementation to add open-telemetry support (reference #2397)
What is this change?
The user can add the open-telemetry configuration in the dab-config.json file as follows:
This configuration can be used alongside the current Application Insights instrumentation, to send logs, traces and metrics to both.
Currently, metrics and traces sent to OTEL comes from AspNetCore and the HttpClients.
The OpenTelemetry implementation only supports dotnet 8.
How was this tested?