Allow for target-defined artifacts #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For simplicity, do you think we can deal with refactoring things in a separate PR? |
Yeah, that's reasonable. |
MorrisLaw
force-pushed
the
allow-artifacts-per-target-definition
branch
from
0733b36 to
28785e4
Compare
MorrisLaw
force-pushed
the
allow-artifacts-per-target-definition
branch
2 times, most recently
from
2a806b0 to
a6472f3
Compare
cpuguy83
requested changes
Feb 10, 2025
MorrisLaw
force-pushed
the
allow-artifacts-per-target-definition
branch
from
3482217 to
8f67ee1
Compare
MorrisLaw
force-pushed
the
allow-artifacts-per-target-definition
branch
from
632e850 to
d3002a8
Compare
cpuguy83
requested changes
Feb 11, 2025
cpuguy83
requested changes
Feb 12, 2025
cpuguy83
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR allows for target-defined artifacts which is especially useful for windows builds.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #474