azlinux/mariner: Use provided platform for outputs #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
use_correct_platforms
branch
4 times, most recently
from
92f97df
to
1dcd0fd
Compare
cpuguy83
force-pushed
the
use_correct_platforms
branch
from
1dcd0fd
to
f1ce1c0
Compare
cpuguy83
force-pushed
the
use_correct_platforms
branch
2 times, most recently
from
e103c78
to
2f39409
Compare
cpuguy83
force-pushed
the
use_correct_platforms
branch
2 times, most recently
from
3a73d76
to
387ca5c
Compare
Before this change, the mariner/azl targets were ignoring the client provided platform for the produced aritifacts. With this change the platform is set on images so it will rely on binfmt_misc to execute those images correctly. There's probably some optimizations that can be made here to run certain tasks on the native platform, some thoughts: - Use native (host-arch) golang to download go modules - Use native (host-arch) tdnf to download/install non-native packages onto the target build environment. This does *not* add support for cross compilation (run x86 code to generate, e.g., arm64 code). Signed-off-by: Brian Goff <[email protected]>
When building for a non-native platform (typically under qemu), use the native platform for most operations that do not need platform specific things, such as applying patches, tarring up sources, and fetching go module deps. Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Brian Goff <[email protected]>
This is an optimization to allow using the native go compiler to cross compile to the desired target. This is transparent to the user. Signed-off-by: Brian Goff <[email protected]>
When cross compiling, use dnf from the native platform to install packages into the target arch rootfs. This helps speed up package install a bit since dnf won't need to run under emulation. Signed-off-by: Brian Goff <[email protected]>
This offers a tremendous speedup for local development. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
use_correct_platforms
branch
from
387ca5c
to
c254fab
Compare
sozercan
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the mariner/azl targets were ignoring the client provided platform for the produced aritifacts.
With this change the platform is set on images so it will rely on binfmt_misc to execute those images correctly.
This also includes some optimizations:
This does not add support for cross compilation (run x86 code to generate, e.g., arm64 code) outside of the specific optimizations listed above.