Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AIB - Several fixes for especially the windows image creation #4051

Merged
merged 47 commits into from
Dec 27, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Dec 27, 2024

Description

  • Enabled windows example
  • Fixed windows customizer steps
  • Added ps-rule suppresion for storage account firewall to enable the solution to pass PS-Rule checks

Note: For a yet unknown reason, the Image Template may not use a custom staging resource group when creating an Image (leads to permission issues)

Pipeline Reference

Pipeline
avm.ptn.virtual-machine-images.azure-image-builder

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Class: Pattern Module 📦 This is a pattern module labels Dec 27, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review December 27, 2024 16:53
@AlexanderSehr AlexanderSehr requested review from a team as code owners December 27, 2024 16:53
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 27, 2024 16:53
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Dec 27, 2024
@AlexanderSehr AlexanderSehr merged commit edbd059 into main Dec 27, 2024
4 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/virtualMachineImagesFix202412_actual branch December 27, 2024 17:06
@@ -0,0 +1,13 @@
---
Copy link
Contributor

@eriqua eriqua Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will trigger all workflows. I'd suggest a separate PR for this and also to agree on how to suppress ad hoc rules as per conversation started by draft PR #3810

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: this has triggered all workflows 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will trigger all workflows. I'd suggest a separate PR for this and also to agree on how to suppress ad hoc rules as per conversation started by draft PR #3810

Fair point. Something we can still do. I hope the item is somewhere on the agenda. My main concern was to get the module unblocked as I was unable to publish any changes since we enforced the security rules. If we change it subsequently to the approach in the linked draft PR it's more than welcome 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants